-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tests/ieee.rs
into smaller files
#93849
Split tests/ieee.rs
into smaller files
#93849
Conversation
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
This seems like a reasonable thing to do, but I'm not sure if splitting into numbered files is the right approach. At the very least I would like to see more meaningful file/module names and grouping. Another concern I have is that a change such as this will cause, if I recall correctly, the build system to link multiple test binaries, thus increasing build times. I feel like these tests should be moved from integration tests back into the in-library |
r? @eddyb Splitting files up just for the sake of it doesn't make sense to me. There's nothing inherently bad about long files, only about lack of organization, and just splitting the files up doesn't introduce more organization. The tidy check is merely a poor approximation of a vague metric, not some kind of golden rule. As anecdotal evidence, I've never really run into issues with very long files, but have had time wasted by unexpected "this part of the code is in some other random place I didn't expect to exist". Also, organization mostly matters for areas of active development. In fact, you can consider |
|
Part of #60302