Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't bind hidden types when searching for matching impls #93859

Closed
wants to merge 4 commits into from
Closed

Don't bind hidden types when searching for matching impls #93859

wants to merge 4 commits into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 10, 2022 •
edited
Loading

fixes #93831
fixes #93821
fixes #93788

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 10, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2022
@oli-obk oli-obk mentioned this pull request Feb 10, 2022
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@apiraino
Copy link
Contributor

apiraino commented Feb 10, 2022 •
edited
Loading

Mentioning also #93821 as possible candidate to be fixed by this, by reading the fist comment in that issue am I correct @oli-obk ?

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure:

@bors
Copy link
Contributor

bors commented Feb 11, 2022

☔ The latest upstream changes (presumably #93893) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 14, 2022

The main lazy TAIT PR has been reverted and these commits will be part of the next attempt

@oli-obk oli-obk closed this Feb 14, 2022
@oli-obk oli-obk deleted the lazy_tait_inference_sadface branch February 14, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
7 participants
@oli-obk @rust-highfive @rust-log-analyzer @apiraino @bors @lcnr @rustbot