Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version numbers to 0.8 #9395

Merged
merged 1 commit into from
Sep 22, 2013
Merged

Update version numbers to 0.8 #9395

merged 1 commit into from
Sep 22, 2013

Conversation

brson
Copy link
Contributor

@brson brson commented Sep 21, 2013

No description provided.

@thestinger
Copy link
Contributor

@alexcrichton: ideally we would set this in the Makefile and have it based on git describe except in a release tarball

if you check out a tag like 0.7, the git describe output will simply be 0.7 and then it will tack on the # of commits since the last tag + the commit id when you go past it

@alexcrichton
Copy link
Member

That sounds like a good idea to me! It looks like the usage falls into three categories:

  • README.md - not sure if this could get automatically updated (I don't think it should either though)
  • *.po files - these are generated, right?
  • src/libX/X.rs - this would involve env!() to work in cfg, although that'd probably make things too annoying to compile by hand.

bors added a commit that referenced this pull request Sep 22, 2013
@bors bors closed this Sep 22, 2013
@bors bors merged commit 695cb9f into rust-lang:master Sep 22, 2013
Jarcho pushed a commit to Jarcho/rust that referenced this pull request Aug 31, 2022
…Manishearth

Fix `suspicious_to_owned` test when `c_char` is `u8`

e.g. on aarch64 linux

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants