Correctly mark the span of captured arguments in format_args!()
#94030
+105
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
issue-94010
branch
from
59f2a8d to
5824840
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
issue-94010
branch
from
5824840 to
2d7b053
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
issue-94010
branch
from
2d7b053 to
a83c9bd
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
issue-94010
branch
2 times, most recently
from
421bf38 to
b771f4f
Compare
petrochenkov
added
S-waiting-on-author
It should only include the identifier, or misspelling suggestions will be wrong.
ChayimFriedman2
force-pushed
the
issue-94010
branch
from
b771f4f to
91adb6c
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
A supurious fail? |
|
The failure looks spurious to me. |
|
📌 Commit 91adb6c has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 16, 2022
…ochenkov Correctly mark the span of captured arguments in `format_args!()` It should not include the braces, or misspelling suggestions will be wrong. Fixes rust-lang#94010.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89869 (Add documentation to more `From::from` implementations.) - rust-lang#93479 (Use `optflag` for `--report-time`) - rust-lang#93693 (Suggest deriving required supertraits) - rust-lang#93981 (Fix suggestion to slice if scurtinee is a reference to `Result` or `Option`) - rust-lang#93996 (Do not suggest "is a function" for free variables) - rust-lang#94030 (Correctly mark the span of captured arguments in `format_args!()`) - rust-lang#94031 ([diagnostics] Add mentions to `Copy` types being valid for `union` fields) - rust-lang#94064 (Update dist-x86_64-musl to Ubuntu 20.04) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 24, 2022
…ochenkov Correctly mark the span of captured arguments in `format_args!()` It should not include the braces, or misspelling suggestions will be wrong. Fixes rust-lang#94010.
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jul 24, 2022
Fix `useless_format` spans for `format!("{foo}")`
Fixes #9234
changelog: [`useless_format`]: Fix spans for `format!("{foo}")`
rust-lang/rust#94030 made our workaround unneeded, but by coincidence our test still passed [because `Span::new()` swaps `hi` & `lo` if needed](https://github.com/rust-lang/rust/blob/c32dcbba187d1ee0dbe92dc152cb9c2f3f42900c/compiler/rustc_span/src/span_encoding.rs#L86-L88). So with a single character variable like `format!("{x}")` it still worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not include the braces, or misspelling suggestions will be wrong.
Fixes #94010.