-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destabilize cfg(target_has_atomic_load_store = ...) #94040
Conversation
This comment has been minimized.
This comment has been minimized.
efe02cd
to
5bd2b1c
Compare
Bumped with a version that re-uses the old cfg_target_has_atomic gate to avoid the compiler-builtins failure. |
This comment has been minimized.
This comment has been minimized.
r=me once CI failure is fixed. |
5bd2b1c
to
62e0678
Compare
This comment has been minimized.
This comment has been minimized.
This was not intended to be stabilized yet.
62e0678
to
fc01d2b
Compare
@bors r=Amanieu p=1 (needed before beta branch on Friday) |
📌 Commit fc01d2b has been approved by |
⌛ Testing commit fc01d2b with merge 02e9008ac62b70bd28e538eb5f519876c10d0b24... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry
|
☀️ Test successful - checks-actions |
Finished benchmarking commit (930fc4f): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This was not intended to be stabilized yet.
This keeps the cfg_target_has_atomic feature gate name since compiler-builtins otherwise depends on it and I'd rather not try to manage a bump across a crates.io published repository given the time-sensitivity here (we need to land this quickly to avoid a beta backport).
Closes #32976
r? @Amanieu