Skip to content

Gat normalization rework #94042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

compiler-errors
Copy link
Member

This commit history is an absolute disaster. Putting this up because I want a perf test!

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 16, 2022
@joshtriplett
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 16, 2022
@bors
Copy link
Collaborator

bors commented Feb 16, 2022

⌛ Trying commit 82d1882 with merge 8681ff519be30cff5621d3862567b09a2c4ada1b...

@bors
Copy link
Collaborator

bors commented Feb 16, 2022

☀️ Try build successful - checks-actions
Build commit: 8681ff519be30cff5621d3862567b09a2c4ada1b (8681ff519be30cff5621d3862567b09a2c4ada1b)

@rust-timer
Copy link
Collaborator

Queued 8681ff519be30cff5621d3862567b09a2c4ada1b with parent 393fdc1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8681ff519be30cff5621d3862567b09a2c4ada1b): comparison url.

Summary: This benchmark run did not return any relevant results. 17 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 16, 2022
@compiler-errors
Copy link
Member Author

Closing in favor of opening a cleaner PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants