Skip to content

register snapshots #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

register snapshots #9415

wants to merge 1 commit into from

Conversation

thestinger
Copy link
Contributor

No description provided.

@thestinger thestinger closed this Sep 23, 2013
@thestinger
Copy link
Contributor Author

These are no good, need to touch the LLVM clean trigger.

flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 9, 2022
@lukaslueg
Fix mut_mutex_lock for Mutex behind imm deref
ffc75af 
Fixes rust-lang#9415
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 9, 2022
@bors
Auto merge of rust-lang#9418 - lukaslueg:issue9415, r=llogiq
c36696a 
Fix `mut_mutex_lock` when Mutex is behind immutable deref

I *think* the problem here is the `if let ty::Ref(_, _, Mutability::Mut) = cx.typeck_results().expr_ty(recv).kind()` line tries to check if the `Mutex` can be mutably borrowed (there already is a test for `Arc<Mutex<_>>`), but gets bamboozled by the `&mut Arc` indirection. And I *think* checking the deref-adjustment to filter immutable-adjust (the deref through the `Arc`, starting from `&mut Arc`) is the correct fix.

Fixes rust-lang#9415

changelog: Fix `mut_mutex_lock` when Mutex is behind immutable deref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thestinger @bors