-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Metadata::modified instead of FileTime::from_last_modification_ti… #94190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me in run_cargo Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
bjorn3
added
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Feb 20, 2022
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Feb 20, 2022
@bors r+ rollup |
📌 Commit b45cb09 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 20, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 20, 2022
…crum Use Metadata::modified instead of FileTime::from_last_modification_ti… …me in run_cargo Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 20, 2022
…crum Use Metadata::modified instead of FileTime::from_last_modification_ti… …me in run_cargo Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 21, 2022
…crum Use Metadata::modified instead of FileTime::from_last_modification_ti… …me in run_cargo Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#91192 (Some improvements to the async docs) - rust-lang#94143 (rustc_const_eval: adopt let else in more places) - rust-lang#94156 (Gracefully handle non-UTF-8 string slices when pretty printing) - rust-lang#94186 (Update pin_static_ref stabilization version.) - rust-lang#94189 (Implement LowerHex on Scalar to clean up their display in rustdoc) - rust-lang#94190 (Use Metadata::modified instead of FileTime::from_last_modification_ti…) - rust-lang#94203 (CTFE engine: Scalar: expose size-generic to_(u)int methods) - rust-lang#94211 (Better error if the user tries to do assignment ... else) - rust-lang#94215 (trait system: comments and small nonfunctional changes) - rust-lang#94220 (Correctly handle miniz_oxide extern crate declaration) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me in run_cargo
Metadata::modified works in all platforms supported by the filetime
crate. This changes brings rustbuild a tiny bit closer towards dropping
the filetime dependency.