-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] Branch 1.60 beta #94228
[beta] Branch 1.60 beta #94228
Conversation
|
@bors r+ rollup=never p=5 |
📌 Commit e5c9e1e has been approved by |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
49b6740
to
95cf544
Compare
nightly_only_test here seems likely to be a little problematic for the future -- probably needs to be revised to avoid fully cfg'ing away the test but rather to mark it as ignore or something like that, at least. |
@bors r+ rollup=never p=5 |
📌 Commit 95cf544 has been approved by |
⌛ Testing commit 95cf544 with merge e51ce066011d7442abf98867f05ab308bd88d165... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
Hmm, how was that not catched by the stable builder? |
rustfmt isn't tested/built on the stable builder, since it's a tool and those aren't checked by x86_64-gnu (the 'template' the stable builder uses). |
Filed racer-rust/racer#1177 to fix racer builds (will need a cargo update at minimum) on parallel rustc, but will try to push up a temporary disable of RLS builds for alt. |
@bors r+ rollup=never p=5 |
📌 Commit 07493dd has been approved by |
happy to chat about this offline to get a better understanding of the concern. i'm a bit puzzled by the failure at first blush because I thought we had sufficiently tricked one matrix of our own CI to think the tests were being executed in a non-nightly, and would've expected this to fail there. apologies! |
⌛ Testing commit 07493dd with merge 308ff258fd84f6ba195b2d439371d33cb4f4f8fa... |
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
r? @Mark-Simulacrum