Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Branch 1.60 beta #94228

Merged
merged 3 commits into from
Feb 22, 2022
Merged

[beta] Branch 1.60 beta #94228

merged 3 commits into from
Feb 22, 2022

Conversation

Mark-Simulacrum
Copy link
Member

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Feb 21, 2022

📌 Commit e5c9e1e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2022
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum
Copy link
Member Author

nightly_only_test here seems likely to be a little problematic for the future -- probably needs to be revised to avoid fully cfg'ing away the test but rather to mark it as ignore or something like that, at least.

@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Feb 21, 2022

📌 Commit 95cf544 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Feb 21, 2022

⌛ Testing commit 95cf544 with merge e51ce066011d7442abf98867f05ab308bd88d165...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Feb 21, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2022
@pietroalbini
Copy link
Member

nightly_only_test here seems likely to be a little problematic for the future -- probably needs to be revised to avoid fully cfg'ing away the test but rather to mark it as ignore or something like that, at least.

Hmm, how was that not catched by the stable builder?

@Mark-Simulacrum
Copy link
Member Author

nightly_only_test here seems likely to be a little problematic for the future -- probably needs to be revised to avoid fully cfg'ing away the test but rather to mark it as ignore or something like that, at least.

Hmm, how was that not catched by the stable builder?

rustfmt isn't tested/built on the stable builder, since it's a tool and those aren't checked by x86_64-gnu (the 'template' the stable builder uses).

@Mark-Simulacrum
Copy link
Member Author

Filed racer-rust/racer#1177 to fix racer builds (will need a cargo update at minimum) on parallel rustc, but will try to push up a temporary disable of RLS builds for alt.

@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Feb 22, 2022

📌 Commit 07493dd has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2022
@calebcartwright
Copy link
Member

nightly_only_test here seems likely to be a little problematic for the future -- probably needs to be revised to avoid fully cfg'ing away the test but rather to mark it as ignore or something like that, at least.

happy to chat about this offline to get a better understanding of the concern. i'm a bit puzzled by the failure at first blush because I thought we had sufficiently tricked one matrix of our own CI to think the tests were being executed in a non-nightly, and would've expected this to fail there.

apologies!

@bors
Copy link
Contributor

bors commented Feb 22, 2022

⌛ Testing commit 07493dd with merge 308ff258fd84f6ba195b2d439371d33cb4f4f8fa...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Feb 22, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 22, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors retry
The hosted runner: GitHub Actions 3 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2022
@bors
Copy link
Contributor

bors commented Feb 22, 2022

⌛ Testing commit 07493dd with merge 0a4f984...

@bors
Copy link
Contributor

bors commented Feb 22, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 0a4f984 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 22, 2022
@bors bors merged commit 0a4f984 into rust-lang:beta Feb 22, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants