Fix show error message when literal overflows in match patterns #94354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
r? @Dylan-DPC |
|
@bors r+ rollup |
|
📌 Commit b0c4db3 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 26, 2022
Fix show error message when literal overflows in match patterns Fix rust-lang#94239 This changes overflow behavior in [fn lit_to_const](https://github.com/rust-lang/rust/blob/master/compiler/rustc_mir_build/src/thir/constant.rs#L10)
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 27, 2022
Fix show error message when literal overflows in match patterns Fix rust-lang#94239 This changes overflow behavior in [fn lit_to_const](https://github.com/rust-lang/rust/blob/master/compiler/rustc_mir_build/src/thir/constant.rs#L10)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 27, 2022
Fix show error message when literal overflows in match patterns Fix rust-lang#94239 This changes overflow behavior in [fn lit_to_const](https://github.com/rust-lang/rust/blob/master/compiler/rustc_mir_build/src/thir/constant.rs#L10)
|
@bors r- I don't really have an explanation for this; in #94405 (comment) two PRs were already merged and the remaining two prs do not cause any functional changes so this pr is the only one thats left 🤔 |
bors
added
S-waiting-on-author
|
The These files contains ❯ rg --fixed-strings --files-with-matches '#![allow(overflowing_literals)]'
library/stdarch/crates/intrinsic-test/src/main.rs
library/stdarch/crates/core_arch/src/x86/aes.rs
library/stdarch/crates/core_arch/src/x86/avx512bitalg.rs
library/stdarch/crates/core_arch/src/x86/avx512vaes.rs
library/stdarch/crates/core_arch/src/x86/avx512gfni.rs
library/stdarch/crates/core_arch/src/x86/pclmulqdq.rs
library/stdarch/crates/core_arch/src/x86/avx512vpclmulqdq.rs
src/test/ui/structs-enums/enum-discrim-autosizing.rs
src/test/ui/structs-enums/enum-discrim-width-stuff.rs
src/test/ui/structs-enums/enum-discrim-range-overflow.rs
src/test/ui/simd/target-feature-mixup.rs
src/test/ui/pattern/usefulness/issue-13727.rs
src/test/ui/packed/packed-struct-generic-layout.rs
src/test/ui/numbers-arithmetic/shift.rs
src/test/ui/numbers-arithmetic/i128.rs
src/test/ui/deriving/deriving-hash.rs
src/test/ui/consts/const-fn-val.rs
src/test/ui/consts/const-rec-and-tup.rs
src/test/ui/consts/const-negation.rs
src/test/ui/array-slice-vec/box-of-array-of-drop-1.rs
src/test/ui/array-slice-vec/box-of-array-of-drop-2.rs
src/test/ui/array-slice-vec/nested-vec-3.rs
src/doc/rust-by-example/src/types/cast.md
library/core/tests/num/dec2flt/mod.rs |
|
Closed due to cast behavior: https://doc.rust-lang.org/stable/rust-by-example/types/cast.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #94239
This changes overflow behavior in fn lit_to_const