Fix inconsistent symbol mangling of integers constants with -Zverbose #94359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
tmiasko
commented
Feb 25, 2022
| //[v0]~| ERROR demangling-alt(<c::Signed<-152>>::f) | ||
| //[legacy]~^^^^ ERROR symbol-name(_ZN1c22Signed$LT$.152_i16$GT$ | ||
| //[legacy]~| ERROR demangling(c::Signed<.152_i16>::f:: | ||
| //[legacy]~| ERROR demangling-alt(c::Signed<.152_i16>::f) |
There was a problem hiding this comment.
The . instead of - seems quite surprising, but preexisting. Apparently -, : and . are mangled the same way, and demangled as ..
tmiasko
force-pushed
the
legacy-verbose-const
branch
from
7ed040e
to
09c1d9f
Compare
The existing v0 tests have been slightly adjusted for compatibility with legacy mangler, which requires an item to have an ancestor in a value namespace or a type namespace to produce a symbol for it. In v0 mangling this results in an extra `Nv` component.
tmiasko
force-pushed
the
legacy-verbose-const
branch
from
09c1d9f
to
8fc60c0
Compare
|
r=me with comments #94359 (comment) added. |
petrochenkov
added
S-waiting-on-author
The `PrettyPrinter` changes formatting of array size and integer constants based on `-Zverbose`, so its implementation cannot be used in legacy symbol mangling.
tmiasko
force-pushed
the
legacy-verbose-const
branch
from
8fc60c0
to
99a7779
Compare
|
@bors r+ |
|
📌 Commit 99a7779 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2022
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#94359 (Fix inconsistent symbol mangling of integers constants with -Zverbose) - rust-lang#94465 (6 - Make more use of `let_chains`) - rust-lang#94470 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PrettyPrinterchanges formatting of array size and integerconstants based on
-Zverbose, so its implementation cannot be used inlegacy symbol mangling.
Example symbol demangling before changes: