-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark uint::wrapping_next_power_of_two
as #[inline]
#94517
Mark uint::wrapping_next_power_of_two
as #[inline]
#94517
Conversation
This brings it in line with `next_power_of_two` and `checked_next_power_of_two`
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
Pretty sure this will be fine but I do wanna do a quick check to see if this impacts perf anywhere @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 3f04c85 with merge 85382c1fc220067f45716e68535acb80754162c9... |
☀️ Try build successful - checks-actions |
Queued 85382c1fc220067f45716e68535acb80754162c9 with parent 1bfe40d, future comparison URL. |
Finished benchmarking commit (85382c1fc220067f45716e68535acb80754162c9): comparison url. Summary: This benchmark run did not return any relevant results. 2 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
alright, that's pretty much what I expected to see. Thank you for the PR! @bors r+ |
📌 Commit 3f04c85 has been approved by |
⌛ Testing commit 3f04c85 with merge a3293c1e2ab78d18cb6fe64ae12901938c18ce8b... |
💥 Test timed out |
@bors retry |
⌛ Testing commit 3f04c85 with merge 1a2ba5044a62efff3fc319edb16197110b6b6bb8... |
💔 Test failed - checks-actions |
uuuuh, not sure what's going on with that test failure... |
☀️ Test successful - checks-actions |
Finished benchmarking commit (4b133a7): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This brings it in line with
next_power_of_two
andchecked_next_power_of_two
https://godbolt.org/z/Tr18GnqKj
Output as of `rustc 1.61.0-nightly (4ce3749 2022-02-28)`