-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always include global target features in function attributes #94579
Conversation
@bors try |
⌛ Trying commit 10fdd56b21c3dbf17c6eae5ad1abbce65137ad62 with merge cdc3d6a5be595fadb021df096cfc2149de5b686e... |
Please verify if cross-lang LTO can inline (regular, non-aes) functions between those built with Also, fixes #94326, right? |
☀️ Try build successful - checks-actions |
I was testing cross-lang LTO with clang 14 from Debian sid and inlining works fine with The issue addressed here seems is most likely responsible for #94326, but I leave this for the original reporter to verify. |
@rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This ensures that information about target features configured with `-C target-feature=...` or detected with `-C target-cpu=native` is retained for subsequent consumers of LLVM bitcode. This is crucial for linker plugin LTO, since this information is not conveyed to the plugin otherwise.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 095d818 with merge 8b23507938335698d132fbfeec3581994b468c68... |
☀️ Try build successful - checks-actions |
Queued 8b23507938335698d132fbfeec3581994b468c68 with parent c8a49fc, future comparison URL. |
Finished benchmarking commit (8b23507938335698d132fbfeec3581994b468c68): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r+ |
📌 Commit 095d818 has been approved by |
⌛ Testing commit 095d818 with merge 81817055727d6d6efc7837463c422ef2b55ea76d... |
💔 Test failed - checks-actions |
dist-x86_64-apple-alt: The hosted runner: GitHub Actions 28 lost communication with the server. @bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c38b8a8): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This ensures that information about target features configured with
-C target-feature=...
or detected with-C target-cpu=native
isretained for subsequent consumers of LLVM bitcode.
This is crucial for linker plugin LTO, since this information is not
conveyed to the plugin otherwise.
Additional test case demonstrating the issue
r? @nagisa