-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[perftest] Update bootstrap LLVM #94677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ba7b6d242c346b7d79168cdac7824e50cba3e39c with merge e9fcc3de4de81bcdce8ff4ab01ae8ad97fc23684... |
☀️ Try build successful - checks-actions |
Queued e9fcc3de4de81bcdce8ff4ab01ae8ad97fc23684 with parent a64180f, future comparison URL. |
Finished benchmarking commit (e9fcc3de4de81bcdce8ff4ab01ae8ad97fc23684): comparison url. Summary: This benchmark run did not return any relevant results. 34 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
Looks like half of max-rss improvement comes from upgrading bootstrap LLVM, other metrics are basically a noise. |
From this PR, but this PR also includes a gcc version bump, and I think we might be using the gcc standard library for something, so it might be due to that. (IOW, I am not sure it is down to LLVM 13 vs. 14 difference). |
Well the newer GCC is needed anyway to build LLVM 14. Could there be some issues with upgrading GCC? It looks like BOLT has a nontrivial effect on its own, but it's good to know that LLVM/GCC upgrade also helps. |
ba7b6d2
to
03faa8a
Compare
This PR is not supposed to be merged, so I'll use it for more LLVM CI experiments. Let's see if gathering more profiling data for PGO for LLVM helps. |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 03faa8a with merge abf097afa10dde1aa3d8a1d422724a46aab79bf3... |
☀️ Try build successful - checks-actions |
Queued abf097afa10dde1aa3d8a1d422724a46aab79bf3 with parent 2631aee, future comparison URL. |
Finished benchmarking commit (abf097afa10dde1aa3d8a1d422724a46aab79bf3): comparison url. Summary: This benchmark run shows 75 relevant improvements 🎉 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
Closing in favour of #95171. |
This PR updates the LLVM used to build
dist
artifacts on CI to version 14. The goal is to see how does this change affect perf (if at all) to isolate the effect of using BOLT.Could someone schedule a perf. run please? Thanks.