Skip to content

[perftest] Update bootstrap LLVM #94677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 6, 2022

This PR updates the LLVM used to build dist artifacts on CI to version 14. The goal is to see how does this change affect perf (if at all) to isolate the effect of using BOLT.

Could someone schedule a perf. run please? Thanks.

@rust-highfive
Copy link
Contributor

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2022
@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2022
@bors
Copy link
Collaborator

bors commented Mar 6, 2022

⌛ Trying commit ba7b6d242c346b7d79168cdac7824e50cba3e39c with merge e9fcc3de4de81bcdce8ff4ab01ae8ad97fc23684...

@bors
Copy link
Collaborator

bors commented Mar 6, 2022

☀️ Try build successful - checks-actions
Build commit: e9fcc3de4de81bcdce8ff4ab01ae8ad97fc23684 (e9fcc3de4de81bcdce8ff4ab01ae8ad97fc23684)

@rust-timer
Copy link
Collaborator

Queued e9fcc3de4de81bcdce8ff4ab01ae8ad97fc23684 with parent a64180f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e9fcc3de4de81bcdce8ff4ab01ae8ad97fc23684): comparison url.

Summary: This benchmark run did not return any relevant results. 34 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2022
@mati865
Copy link
Contributor

mati865 commented Mar 6, 2022

Looks like half of max-rss improvement comes from upgrading bootstrap LLVM, other metrics are basically a noise.

@Mark-Simulacrum
Copy link
Member

From this PR, but this PR also includes a gcc version bump, and I think we might be using the gcc standard library for something, so it might be due to that. (IOW, I am not sure it is down to LLVM 13 vs. 14 difference).

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 7, 2022

Well the newer GCC is needed anyway to build LLVM 14. Could there be some issues with upgrading GCC?

It looks like BOLT has a nontrivial effect on its own, but it's good to know that LLVM/GCC upgrade also helps.

@Kobzol Kobzol force-pushed the llvm-bootstrap-update branch from ba7b6d2 to 03faa8a Compare March 7, 2022 08:50
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 7, 2022

This PR is not supposed to be merged, so I'll use it for more LLVM CI experiments. Let's see if gathering more profiling data for PGO for LLVM helps.

@lqd
Copy link
Member

lqd commented Mar 7, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 7, 2022
@bors
Copy link
Collaborator

bors commented Mar 7, 2022

⌛ Trying commit 03faa8a with merge abf097afa10dde1aa3d8a1d422724a46aab79bf3...

@bors
Copy link
Collaborator

bors commented Mar 7, 2022

☀️ Try build successful - checks-actions
Build commit: abf097afa10dde1aa3d8a1d422724a46aab79bf3 (abf097afa10dde1aa3d8a1d422724a46aab79bf3)

@rust-timer
Copy link
Collaborator

Queued abf097afa10dde1aa3d8a1d422724a46aab79bf3 with parent 2631aee, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (abf097afa10dde1aa3d8a1d422724a46aab79bf3): comparison url.

Summary: This benchmark run shows 75 relevant improvements 🎉 to instruction counts.

  • Arithmetic mean of relevant improvements: -2.6%
  • Largest improvement in instruction counts: -5.0% on incr-full builds of webrender debug

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 24, 2022

Closing in favour of #95171.

@Kobzol Kobzol closed this Mar 24, 2022
@Kobzol Kobzol deleted the llvm-bootstrap-update branch March 24, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants