Remove whitespaces and use CSS to align line numbers to the right instead #94696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
notriddle
approved these changes
Mar 7, 2022
|
@bors r+ rollup |
|
📌 Commit f23d6d3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2022
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#93350 (libunwind: readd link attrs to _Unwind_Backtrace) - rust-lang#93827 (Stabilize const_fn_fn_ptr_basics, const_fn_trait_bound, and const_impl_trait) - rust-lang#94696 (Remove whitespaces and use CSS to align line numbers to the right instead) - rust-lang#94700 (rustdoc: Update minifier version) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 14, 2022
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#93350 (libunwind: readd link attrs to _Unwind_Backtrace) - rust-lang#93827 (Stabilize const_fn_fn_ptr_basics, const_fn_trait_bound, and const_impl_trait) - rust-lang#94696 (Remove whitespaces and use CSS to align line numbers to the right instead) - rust-lang#94700 (rustdoc: Update minifier version) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating whitespaces to create padding, we simply use the CSS rule:
text-align: right.Nice side-effect: it reduces the generated HTML size from 75.004 to 74.828 (MegaBytes) on the std source pages (it's not much but it's always a nice plus 😆 ).
There are no changes in the generated UI.
r? @notriddle