Rollup of 10 pull requests #95056
Merged
Rollup of 10 pull requests #95056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Holk <eric@theincredibleholk.org>
This is all almost certainly wrong
Also includes a lengthy comment arguing the correctness. Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
This is a continuation of rust-lang#60109, which noted that while the ADX intrinsics were stabilized, the corresponding target feature never was. This PR follows the same general structure and stabilizes the ADX target feature.
Signed-off-by: codehorseman <cricis@yeah.net>
There are a few places were we have to construct it, though, and a few places that are more invasive to change. To do this, we create a constructor with a long obvious name.
…jackh726 Improve `unsafe` diagnostic This fixes: rust-lang#90880 I didn't use the exact proposed messages though.
Make ErrorReported impossible to construct outside `rustc_errors` There are a few places were we have to construct it, though, and a few places that are more invasive to change. To do this, we create a constructor with a long obvious name. cc rust-lang#69426 `@varkor` `@eddyb` `@estebank` I actually didn't see that I was assigned to this issue until now...
Stabilize ADX target feature This is a continuation of rust-lang#60109, which noted that while the ADX intrinsics were stabilized, the corresponding target feature never was. This PR follows the same general structure and stabilizes the ADX target feature. See also rust-lang#44839 - tracking issue for target feature
[generator_interior] Be more precise with scopes of borrowed places
Previously the generator interior type checking analysis would use the nearest temporary scope as the scope of a borrowed value. This ends up being overly broad for cases such as:
```rust
fn status(_client_status: &Client) -> i16 {
200
}
fn main() {
let client = Client;
let g = move || match status(&client) {
_status => yield,
};
assert_send(g);
}
```
In this case, the borrow `&client` could be considered in scope for the entirety of the `match` expression, meaning it would be viewed as live across the `yield`, therefore making the generator not `Send`.
In most cases, we want to use the enclosing expression as the scope for a borrowed value which will be less than or equal to the nearest temporary scope. This PR changes the analysis to use the enclosing expression as the scope for most borrows, with the exception of borrowed RValues which are true temporary values that should have the temporary scope. There's one further exception where borrows of a copy such as happens in autoref cases also should be ignored despite being RValues.
Joint work with `@nikomatsakis`
Fixes rust-lang#57017
r? `@tmandry`
…ons, r=estebank Remove redundant code from copy-suggestions Follow up to rust-lang#94375, just remove some code that is not necessary anymore. This may make the perf of such suggestions a little bit worse, but I don't think this is significant. r? `@estebank`
…, r=davidtwco,oli-obk
Suggest adding `{ .. }` around a const function call with arguments
closes rust-lang#91020
Fix many spelling mistakes Signed-off-by: codehorseman <cricis@yeah.net>
…n-DPC Add deprecated_safe feature gate and attribute, cc rust-lang#94978
…-layout-error, r=wesleywiser debuginfo: Fix ICE when generating name for type that produces a layout error. Fixes rust-lang#94961.
…-Simulacrum Fixed wrong type name in comment 95kth issue/pr!
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit 4493826 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Mar 18, 2022
|
Finished benchmarking commit (cd11905): comparison url. Summary: This benchmark run did not return any relevant results. 21 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
unsafediagnostic #91133 (Improveunsafediagnostic)rustc_errors#93222 (Make ErrorReported impossible to construct outsiderustc_errors){ .. }around a const function call with arguments #94731 (Suggest adding{ .. }around a const function call with arguments)#[deprecated_safe]attribute #94978)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup