Suggest constraining param for unary ops when missing trait impl #95197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
frank-king
commented
Mar 22, 2022
| visitor.visit_ty(operand_ty); | ||
| if let [ty] = &visitor.0[..] { | ||
| if let ty::Param(p) = *operand_ty.kind() { | ||
| suggest_constraining_param( |
There was a problem hiding this comment.
Here I just followed what check_overloaded_binop does, I'm not sure if the passed arguments are right.
|
@bors r+ |
|
📌 Commit f28d8b1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#95188 ([`macro-metavar-expr`] Fix generated tokens hygiene) - rust-lang#95196 (rename LocalState::Uninitialized to Unallocated) - rust-lang#95197 (Suggest constraining param for unary ops when missing trait impl) - rust-lang#95200 (Cancel a not emitted error after parsing const generic args) - rust-lang#95207 (update Termination trait docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a suggestion of constraining param for unary ops
-and!when the corresponding trait implementationis missing.
Fixs #94543.
BTW, this is my first time to touch rustc, please correct me if I did anything wrong.