Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add #[must_use] to functions of slice and its iterators. #95274

Merged
merged 6 commits into from
Mar 26, 2022
Merged

add #[must_use] to functions of slice and its iterators. #95274

merged 6 commits into from
Mar 26, 2022

Conversation

jendrikw
Copy link
Contributor

Continuation of #92853.

Tracking issue: #89692.

@jendrikw jendrikw mentioned this pull request Mar 24, 2022
Closed
@Dylan-DPC
Copy link
Member

r? @Dylan-DPC

@Dylan-DPC
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2022

📌 Commit dcdde01 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 26, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#95274 - jendrikw:slice-must-use, r=Dylan-DPC
b9fcbc3 
add #[must_use] to functions of slice and its iterators.

Continuation of rust-lang#92853.

Tracking issue: rust-lang#89692.
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 26, 2022
Closed
@Dylan-DPC
Copy link
Member

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2022
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 26, 2022
@Dylan-DPC
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2022

📌 Commit 5f88c23 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2022
@bors
Copy link
Contributor

bors commented Mar 26, 2022

⌛ Testing commit 5f88c23 with merge 78da86cb08fc3f52a17628bda3d9992d837234e7...

@bors
Copy link
Contributor

bors commented Mar 26, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jendrikw
Copy link
Contributor Author

Spurios 403 from crates.io (failed to get 200 response from `[https://crates.io/api/v1/crates/gimli/0.25.0/download`,](https://crates.io/api/v1/crates/gimli/0.25.0/download%60,) got 403)

@bors retry

@bors
Copy link
Contributor

bors commented Mar 26, 2022

@jendrikw: 🔑 Insufficient privileges: not in try users

@jendrikw
Copy link
Contributor Author

This permission model seems kind of flawed when I can bypass it just by pushing an empty commit...

@bors
Copy link
Contributor

bors commented Mar 26, 2022

⌛ Testing commit 763094b with merge d47b0fb8223259c829a0ca20eaed364c191cd2fa...

@bors
Copy link
Contributor

bors commented Mar 26, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2022
@Dylan-DPC
Copy link
Member

@bors treeclosed=100

@ehuss
Copy link
Contributor

ehuss commented Mar 26, 2022

@bors retry
crates.io 403

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2022
@ehuss
Copy link
Contributor

ehuss commented Mar 26, 2022

@bors p=101

@bors bors mentioned this pull request Mar 26, 2022
Merged
@bors
Copy link
Contributor

bors commented Mar 26, 2022

⌛ Testing commit 763094b with merge 1d9c262...

@nagisa
Copy link
Member

nagisa commented Mar 26, 2022

Note: I have seen a 403 today myself. The error is spurious and will most likely go away after a retry.

@Dylan-DPC
Copy link
Member

@nagisa several prs have been failing with the same problem from last 1-2 hours

This was referenced Mar 26, 2022
Merged
Merged
Merged
@klensy klensy mentioned this pull request Mar 26, 2022
Closed
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-log-analyzer
Copy link
Collaborator

The job dist-mips-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Mar 26, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 1d9c262 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 26, 2022
@bors bors merged commit 1d9c262 into rust-lang:master Mar 26, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 26, 2022
This was referenced Mar 26, 2022
Merged
Closed
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d9c262): comparison url.

Summary: This benchmark run did not return any relevant results. 4 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 7, 2022
@bors
Auto merge of rust-lang#95274 - jendrikw:slice-must-use, r=Dylan-DPC
a7da8a6 
add #[must_use] to functions of slice and its iterators.

Continuation of rust-lang#92853.

Tracking issue: rust-lang#89692.
@dtolnay dtolnay mentioned this pull request Mar 11, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
8 participants
@jendrikw @Dylan-DPC @bors @rust-log-analyzer @ehuss @nagisa @rust-timer @rustbot