-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Linux kernel handoff in std::io::copy and std::fs::copy #95294
Conversation
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that there should be some indication here that these descriptions fall under the set of caveats explained in std::io's "Platform-specific behavior" documentation.
Either like this:
Lines 28 to 31 in ee915c3
/// This function [currently] corresponds to the `getcwd` function on Unix | |
/// and the `GetCurrentDirectoryW` function on Windows. | |
/// | |
/// [currently]: crate::io#platform-specific-behavior |
or like this:
Lines 545 to 549 in ee915c3
/// This function currently corresponds to the `fchmod` function on Unix and | |
/// the `SetFileInformationByHandle` function on Windows. Note that, this | |
/// [may change in the future][changes]. | |
/// | |
/// [changes]: io#platform-specific-behavior |
OK will do. |
Done, please take another look. r? @dtolnay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ rollup |
📌 Commit cfee2ed has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#95294 (Document Linux kernel handoff in std::io::copy and std::fs::copy) - rust-lang#95443 (Clarify how `src/tools/x` searches for python) - rust-lang#95452 (fix since field version for termination stabilization) - rust-lang#95460 (Spellchecking compiler code) - rust-lang#95461 (Spellchecking some comments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
No description provided.