Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double drop of allocator in IntoIter impl of Vec #95298

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Fix double drop of allocator in IntoIter impl of Vec #95298

merged 4 commits into from
Mar 31, 2022

Commits on Mar 25, 2022

  1. Fix double drop of allocator in IntoIter impl of Vec

    @jhorstmann
    jhorstmann committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    0cf6061 View commit details
    Browse the repository at this point in the history

  2. Use ManuallyDrop::take instead of into_inner 

    Co-authored-by: Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>
    @jhorstmann @danielhenrymantilla
    jhorstmann and danielhenrymantilla authored Mar 25, 2022
    Configuration menu
    Copy the full SHA
    d14c0d2 View commit details
    Browse the repository at this point in the history

  3. Add a test verifying the number of drop calls

    @jhorstmann
    jhorstmann committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    4b53f56 View commit details
    Browse the repository at this point in the history

  4. Add another assertion without into_iter

    @jhorstmann
    jhorstmann committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    d9a438d View commit details
    Browse the repository at this point in the history