Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster parsing for lower numbers for radix up to 16 (cont.) #95399

Merged
merged 15 commits into from
Apr 12, 2022
Merged

Faster parsing for lower numbers for radix up to 16 (cont.) #95399

merged 15 commits into from
Apr 12, 2022

Commits on Mar 26, 2022

  1. faster parsing when not possible to overflow

    @gilescope
    gilescope committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    0a11090 View commit details
    Browse the repository at this point in the history

  2. add likely and clearer comments

    @gilescope
    gilescope committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    13d85ea View commit details
    Browse the repository at this point in the history

  3. Update library/core/src/num/mod.rs 

    Co-authored-by: LingMan <LingMan@users.noreply.github.com>
    @gilescope @LingMan
    gilescope and LingMan committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    48b7cc4 View commit details
    Browse the repository at this point in the history

  4. Update library/core/src/num/mod.rs 

    Co-authored-by: LingMan <LingMan@users.noreply.github.com>
    @gilescope @LingMan
    gilescope and LingMan committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    b9923a8 View commit details
    Browse the repository at this point in the history

  5. removed likely

    @gilescope
    gilescope committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    70b04fd View commit details
    Browse the repository at this point in the history

  6. Update library/core/src/num/mod.rs 

    Co-authored-by: Ivan Tham <pickfire@riseup.net>
    @gilescope @pickfire
    gilescope and pickfire committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    e898257 View commit details
    Browse the repository at this point in the history

  7. Better explanation

    @gilescope
    gilescope committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    5f78bb4 View commit details
    Browse the repository at this point in the history

  8. Update library/core/src/num/mod.rs 

    Co-authored-by: LingMan <LingMan@users.noreply.github.com>
    @gilescope @LingMan
    gilescope and LingMan committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    e93d03b View commit details
    Browse the repository at this point in the history

  9. Using macro to avoid performance hit (thanks LingMan)

    @gilescope
    gilescope committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    d27454e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2022

  1. incorporating feedback

    @gilescope
    gilescope committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    4bfea71 View commit details
    Browse the repository at this point in the history

  2. need guidence on testing

    @gilescope
    gilescope committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    72a5e7e View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. from_u32(0) can just be default()

    @gilescope
    gilescope committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    82e9d9e View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Use Add, Sub, Mul traits instead of unsafe

    @gilescope
    gilescope committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    515906a View commit details
    Browse the repository at this point in the history

  2. No need to use Default

    @gilescope
    gilescope committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    79e8653 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. better def of is signed in tests.

    @gilescope
    gilescope committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    3ee7bb1 View commit details
    Browse the repository at this point in the history