-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] some mir typeck cleanup #95763
Conversation
The job Click to see the possible cause of the failure (guessed by this bot)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me so far! is this still a WIP?
)) | ||
.to_predicate(self.tcx()), | ||
location.to_locations(), | ||
ConstraintCategory::Boring, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a known bug that is affected by this?
.to_predicate(self.tcx()), | ||
location.to_locations(), | ||
ConstraintCategory::Boring, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't we file a bug about this?
☔ The latest upstream changes (presumably #96528) made this pull request unmergeable. Please resolve the merge conflicts. |
lcnr reports that this still has a nasty bug that they need to work out. @rustbot label: +S-waiting-on-author -S-waiting-on-review |
closing in favor of #100761, I intend to work on the the refactorings I've dropped at a later date |
…r-errors some general mir typeck cleanup this pr contains the parts of rust-lang#95763 which already work correctly. the remaining commits of that PR have some issues which are more complex to fix. r? types
…r-errors some general mir typeck cleanup this pr contains the parts of rust-lang#95763 which already work correctly. the remaining commits of that PR have some issues which are more complex to fix. r? types
…r-errors some general mir typeck cleanup this pr contains the parts of rust-lang#95763 which already work correctly. the remaining commits of that PR have some issues which are more complex to fix. r? types
…r-errors some general mir typeck cleanup this pr contains the parts of rust-lang#95763 which already work correctly. the remaining commits of that PR have some issues which are more complex to fix. r? types
…r-errors some general mir typeck cleanup this pr contains the parts of rust-lang#95763 which already work correctly. the remaining commits of that PR have some issues which are more complex to fix. r? types
…r-errors some general mir typeck cleanup this pr contains the parts of rust-lang#95763 which already work correctly. the remaining commits of that PR have some issues which are more complex to fix. r? types
TODO: write this
r? @nikomatsakis