Check for git submodules in non-git source tree. #95849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
This seems ok to me - we can also probably have triagebot attach an extra file (these-are-not-the-sources-you-want) or something as a poor indicator, and maybe have a note at the end of the release note text inserted that says what this PR adds to x.py. Going to go ahead and approve as a good change regardless most likely. @bors r+ |
|
📌 Commit ca9ef27 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 10, 2022
…lacrum Check for git submodules in non-git source tree. People occasionally download the source from https://github.com/rust-lang/rust/releases, but those source distributions will not work because they are missing the submodules. They will get a confusing `failed to load manifest for workspace member` error. Unfortunately AFAIK there is no way to disable the GitHub source links. This change tries to detect this scenario and provide an error message that guides them toward a solution. Closes rust-lang#95608
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#95566 (Avoid duplication of doc comments in `std::char` constants and functions) - rust-lang#95784 (Suggest replacing `typeof(...)` with an actual type) - rust-lang#95807 (Suggest adding a local for vector to fix borrowck errors) - rust-lang#95849 (Check for git submodules in non-git source tree.) - rust-lang#95852 (Fix missing space in lossy provenance cast lint) - rust-lang#95857 (Allow multiple derefs to be splitted in deref_separator) - rust-lang#95868 (rustdoc: Reduce allocations in a `html::markdown` function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People occasionally download the source from https://github.com/rust-lang/rust/releases, but those source distributions will not work because they are missing the submodules. They will get a confusing
failed to load manifest for workspace membererror.Unfortunately AFAIK there is no way to disable the GitHub source links. This change tries to detect this scenario and provide an error message that guides them toward a solution.
Closes #95608