Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify String::from_utf16 #95853

Closed
wants to merge 1 commit into from
Closed

Simplify String::from_utf16 #95853

wants to merge 1 commit into from

Conversation

Serial-ATA
Copy link
Contributor

#48994 was closed awhile ago, so I assume it's fine to simplify this again.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2022
@dylni
Copy link
Contributor

dylni commented Apr 9, 2022

Unfortunately, this is not equivalent yet: #92138 (comment)

dtolnay
dtolnay reviewed Apr 16, 2022
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reopened #48994.

Thanks anyway!

@dtolnay dtolnay closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Serial-ATA @rust-highfive @dylni @dtolnay