Thin `AssocItem` #95884

cjgillot · 2022-04-10T15:52:17Z

This PR removes a few fields from AssocItem that should be easily computed using other queries.
This simplifies some of the metadata decoding.

bors · 2022-04-11T14:37:10Z

☔ The latest upstream changes (presumably #95931) made this pull request unmergeable. Please resolve the merge conflicts.

cjgillot · 2022-07-30T14:38:05Z

@bors try @rust-timer queue

rust-timer · 2022-07-30T14:38:06Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-30T14:38:13Z

⌛ Trying commit b17e94966ca80bf15c89506ec454045e02ea2eba with merge 900520465146285405f968f619001b5f7eb21c7a...

bors · 2022-07-30T14:52:51Z

💔 Test failed - checks-actions

cjgillot · 2022-07-30T15:18:01Z

@bors try @rust-timer queue

rust-timer · 2022-07-30T15:18:02Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-30T15:18:09Z

⌛ Trying commit 09a25c3c8553868c930bb312c2193d88f5601309 with merge 09bd25116aaa08279ee6842808402afe18c82967...

cjgillot · 2022-07-30T16:44:23Z

@bors try @rust-timer queue

rust-timer · 2022-07-30T16:44:25Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-30T16:44:32Z

⌛ Trying commit 0b36938cbf416c9701250d31ae6e44e00379700d with merge a5ebbfe4684f0bac93cb0b0b3c5a00e3940d3901...

bors · 2022-07-30T18:37:59Z

☀️ Try build successful - checks-actions
Build commit: a5ebbfe4684f0bac93cb0b0b3c5a00e3940d3901 (a5ebbfe4684f0bac93cb0b0b3c5a00e3940d3901)

rust-timer · 2022-07-30T18:38:01Z

Queued a5ebbfe4684f0bac93cb0b0b3c5a00e3940d3901 with parent c907b6f, future comparison URL.

rust-timer · 2022-07-30T20:02:40Z

Finished benchmarking commit (a5ebbfe4684f0bac93cb0b0b3c5a00e3940d3901): comparison url.

Instruction count

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	0.3%	0.5%	16
Regressions 😿 (secondary)	0.5%	0.6%	13
Improvements 🎉 (primary)	-0.3%	-0.4%	7
Improvements 🎉 (secondary)	-0.4%	-0.5%	4
All 😿🎉 (primary)	0.1%	0.5%	23

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.2%	4.0%	2
Improvements 🎉 (primary)	-1.8%	-3.2%	4
Improvements 🎉 (secondary)	-3.0%	-4.1%	3
All 😿🎉 (primary)	-1.8%	-3.2%	4

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	2.4%	2.4%	1
Regressions 😿 (secondary)	2.3%	2.5%	2
Improvements 🎉 (primary)	-2.2%	-2.2%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.1%	2.4%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

bors · 2022-08-01T18:43:45Z

☔ The latest upstream changes (presumably #100024) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-08-01T18:43:52Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout assoc-item (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self assoc-item --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging src/librustdoc/clean/mod.rs
Auto-merging src/librustdoc/clean/inline.rs
Auto-merging compiler/rustc_typeck/src/check/fn_ctxt/_impl.rs
Auto-merging compiler/rustc_typeck/src/check/demand.rs
Auto-merging compiler/rustc_typeck/src/astconv/mod.rs
Auto-merging compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Auto-merging compiler/rustc_privacy/src/lib.rs
Auto-merging compiler/rustc_mir_build/src/lints.rs
Auto-merging compiler/rustc_middle/src/ty/context.rs
Auto-merging compiler/rustc_middle/src/query/mod.rs
Auto-merging compiler/rustc_hir/src/hir.rs
CONFLICT (content): Merge conflict in compiler/rustc_hir/src/hir.rs
Automatic merge failed; fix conflicts and then commit the result.

cjgillot · 2022-08-01T21:37:25Z

@bors r=lcnr

bors · 2022-08-01T21:37:27Z

📌 Commit 212a06e has been approved by lcnr

It is now in the queue for this repository.

bors · 2022-08-01T21:43:38Z

⌛ Testing commit 212a06e with merge 21de280...

bors · 2022-08-02T00:39:11Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 21de280 to master...

rust-timer · 2022-08-02T02:28:37Z

Finished benchmarking commit (21de280): comparison url.

Instruction count

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	0.3%	0.4%	16
Regressions 😿 (secondary)	0.5%	0.6%	9
Improvements 🎉 (primary)	-0.3%	-0.4%	7
Improvements 🎉 (secondary)	-0.4%	-0.5%	8
All 😿🎉 (primary)	0.1%	0.4%	23

Max RSS (memory usage)

Results

Primary benchmarks: mixed results
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	2.3%	2.3%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-1.2%	-3.1%	5
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.6%	-3.1%	6

Cycles

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.7%	-2.7%	1
Improvements 🎉 (secondary)	-2.6%	-2.6%	1
All 😿🎉 (primary)	-2.7%	-2.7%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

nnethercote · 2022-08-02T02:58:44Z

This looks perf-neutral, with the improvements roughly the same size as the regressions.

@rustbot label: +perf-regression-triaged

ethe · 2022-08-02T06:04:48Z

get panic in any cargo projects building after this PR, delete building cache of projects and panic is resolved.
panic logs:

 ↳ cargo build
   Compiling research v0.1.0 (/data00/home/autohime/research)
error: internal compiler error: encountered incremental compilation error with late_bound_vars_map(research[9e26]::_call)
  |
  = help: This is a known issue with the compiler. Run `cargo clean -p research` or `cargo clean` to allow your project to compile
  = note: Please follow the instructions below to create a bug report with the provided information
  = note: See <https://github.com/rust-lang/rust/issues/84970> for more information

thread 'rustc' panicked at 'Found unstable fingerprints for late_bound_vars_map(research[9e26]::_call): Some({0: [], 61: [], 20: [], 81: [], 72: [Region(BrNamed(DefId(0:9 ~ research[9e26]::_call::'s), 's)), Region(BrNamed(DefId(0:10 ~ research[9e26]::_call::'cx), 'cx))], 69: [], 66: [], 79: [Region(BrNamed(DefId(0:9 ~ research[9e26]::_call::'s), 's)), Region(BrNamed(DefId(0:10 ~ research[9e26]::_call::'cx), 'cx))]})', compiler/rustc_query_system/src/query/plumbing.rs:627:9
stack backtrace:
   0:     0x7fb4bd05e474 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h1525352d64489be5
   1:     0x7fb4bd0d788e - core::fmt::write::he0cdbcb1b4f9137e
   2:     0x7fb4bd0475a1 - std::io::Write::write_fmt::h5ac120bcc89a9711
   3:     0x7fb4bd05e2c9 - std::sys_common::backtrace::print::h357844ba9e23590a
   4:     0x7fb4bd0480a7 - std::panicking::default_hook::{{closure}}::h046e90d133347414
   5:     0x7fb4bd047ed3 - std::panicking::default_hook::h5e50f9108c63488b
   6:     0x7fb4bd8f4f74 - rustc_driver[a177c53ac2cf0051]::DEFAULT_HOOK::{closure#0}::{closure#0}
   7:     0x7fb4bd0484a8 - std::panicking::rust_panic_with_hook::hb9114b8583c4cdf6
   8:     0x7fb4bd0564e7 - std::panicking::begin_panic_handler::{{closure}}::h7518f7cb4822dfdc
   9:     0x7fb4bd056424 - std::sys_common::backtrace::__rust_end_short_backtrace::he6f9aab0edfe27da
  10:     0x7fb4bd048172 - rust_begin_unwind
  11:     0x7fb4bd02a0d3 - core::panicking::panic_fmt::hb8c3375d42574ff4
  12:     0x7fb4bd8cc300 - rustc_query_system[5961241f39e0d58f]::query::plumbing::incremental_verify_ich_cold
  13:     0x7fb4bed71569 - rustc_query_system[5961241f39e0d58f]::query::plumbing::incremental_verify_ich::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt, rustc_span[18a919f8c0850d33]::def_id::LocalDefId, core[5571ea7c97e175b]::option::Option<&std[a2c7089b4b8c7571]::collections::hash::map::HashMap<rustc_hir[bd57e2855bf4af64]::hir_id::ItemLocalId, alloc[d30d5095469b2716]::vec::Vec<rustc_middle[5d1ff1ffbdb84c71]::ty::sty::BoundVariableKind>, core[5571ea7c97e175b]::hash::BuildHasherDefault<rustc_hash[4aa44f1efe9a28e9]::FxHasher>>>>
  14:     0x7fb4bedaa4f8 - rustc_query_system[5961241f39e0d58f]::query::plumbing::try_load_from_disk_and_cache_in_memory::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt, rustc_span[18a919f8c0850d33]::def_id::LocalDefId, core[5571ea7c97e175b]::option::Option<&std[a2c7089b4b8c7571]::collections::hash::map::HashMap<rustc_hir[bd57e2855bf4af64]::hir_id::ItemLocalId, alloc[d30d5095469b2716]::vec::Vec<rustc_middle[5d1ff1ffbdb84c71]::ty::sty::BoundVariableKind>, core[5571ea7c97e175b]::hash::BuildHasherDefault<rustc_hash[4aa44f1efe9a28e9]::FxHasher>>>>
  15:     0x7fb4bed18bad - rustc_query_system[5961241f39e0d58f]::query::plumbing::try_execute_query::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt, rustc_query_system[5961241f39e0d58f]::query::caches::DefaultCache<rustc_span[18a919f8c0850d33]::def_id::LocalDefId, core[5571ea7c97e175b]::option::Option<&std[a2c7089b4b8c7571]::collections::hash::map::HashMap<rustc_hir[bd57e2855bf4af64]::hir_id::ItemLocalId, alloc[d30d5095469b2716]::vec::Vec<rustc_middle[5d1ff1ffbdb84c71]::ty::sty::BoundVariableKind>, core[5571ea7c97e175b]::hash::BuildHasherDefault<rustc_hash[4aa44f1efe9a28e9]::FxHasher>>>>>
  16:     0x7fb4bede9ba4 - rustc_query_system[5961241f39e0d58f]::query::plumbing::get_query::<rustc_query_impl[b30ae0b18ffa5f8d]::queries::late_bound_vars_map, rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt>
  17:     0x7fb4bec9291d - <rustc_query_impl[b30ae0b18ffa5f8d]::Queries as rustc_middle[5d1ff1ffbdb84c71]::ty::query::QueryEngine>::late_bound_vars_map
  18:     0x7fb4bfabddf8 - <rustc_middle[5d1ff1ffbdb84c71]::ty::context::TyCtxt>::late_bound_vars
  19:     0x7fb4be29c798 - rustc_typeck[2b53629f01fad2c1]::collect::gather_explicit_predicates_of
  20:     0x7fb4be29e1d0 - rustc_typeck[2b53629f01fad2c1]::collect::explicit_predicates_of
  21:     0x7fb4bee3ba55 - <rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind as rustc_query_system[5961241f39e0d58f]::dep_graph::DepKind>::with_deps::<<rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle[5d1ff1ffbdb84c71]::ty::context::TyCtxt, rustc_span[18a919f8c0850d33]::def_id::DefId, rustc_middle[5d1ff1ffbdb84c71]::ty::generics::GenericPredicates>::{closure#0}, rustc_middle[5d1ff1ffbdb84c71]::ty::generics::GenericPredicates>
  22:     0x7fb4bef64522 - <rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::with_task::<rustc_middle[5d1ff1ffbdb84c71]::ty::context::TyCtxt, rustc_span[18a919f8c0850d33]::def_id::DefId, rustc_middle[5d1ff1ffbdb84c71]::ty::generics::GenericPredicates>
  23:     0x7fb4bed3fb0b - rustc_query_system[5961241f39e0d58f]::query::plumbing::try_execute_query::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt, rustc_query_system[5961241f39e0d58f]::query::caches::DefaultCache<rustc_span[18a919f8c0850d33]::def_id::DefId, rustc_middle[5d1ff1ffbdb84c71]::ty::generics::GenericPredicates>>
  24:     0x7fb4becdf16a - rustc_query_system[5961241f39e0d58f]::query::plumbing::force_query::<rustc_query_impl[b30ae0b18ffa5f8d]::queries::explicit_predicates_of, rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt>
  25:     0x7fb4bf09d9c6 - rustc_query_impl[b30ae0b18ffa5f8d]::query_callbacks::explicit_predicates_of::force_from_dep_node
  26:     0x7fb4bfaa6d97 - <rustc_middle[5d1ff1ffbdb84c71]::ty::context::TyCtxt as rustc_query_system[5961241f39e0d58f]::dep_graph::DepContext>::try_force_from_dep_node
  27:     0x7fb4bef365e6 - <rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt>
  28:     0x7fb4bef36432 - <rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt>
  29:     0x7fb4beef975c - <rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::try_mark_green::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt>
  30:     0x7fb4bece83c8 - rustc_query_system[5961241f39e0d58f]::query::plumbing::ensure_must_run::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt, rustc_span[18a919f8c0850d33]::def_id::DefId, alloc[d30d5095469b2716]::vec::Vec<&rustc_middle[5d1ff1ffbdb84c71]::mir::coverage::CodeRegion>>
  31:     0x7fb4bedd3ea2 - rustc_query_system[5961241f39e0d58f]::query::plumbing::get_query::<rustc_query_impl[b30ae0b18ffa5f8d]::queries::predicates_of, rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt>
  32:     0x7fb4bec6071e - <rustc_query_impl[b30ae0b18ffa5f8d]::Queries as rustc_middle[5d1ff1ffbdb84c71]::ty::query::QueryEngine>::predicates_of
  33:     0x7fb4be2933c1 - rustc_typeck[2b53629f01fad2c1]::collect::convert_item
  34:     0x7fb4be28e98a - <rustc_typeck[2b53629f01fad2c1]::collect::CollectItemTypesVisitor as rustc_hir[bd57e2855bf4af64]::intravisit::Visitor>::visit_item
  35:     0x7fb4be353220 - <rustc_middle[5d1ff1ffbdb84c71]::hir::map::Map>::visit_item_likes_in_module::<rustc_typeck[2b53629f01fad2c1]::collect::CollectItemTypesVisitor>
  36:     0x7fb4be28e0cd - rustc_typeck[2b53629f01fad2c1]::collect::collect_mod_item_types
  37:     0x7fb4bee39c2d - <rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind as rustc_query_system[5961241f39e0d58f]::dep_graph::DepKind>::with_deps::<<rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle[5d1ff1ffbdb84c71]::ty::context::TyCtxt, rustc_span[18a919f8c0850d33]::def_id::LocalDefId, ()>::{closure#0}, ()>
  38:     0x7fb4bef56b5c - <rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::with_task::<rustc_middle[5d1ff1ffbdb84c71]::ty::context::TyCtxt, rustc_span[18a919f8c0850d33]::def_id::LocalDefId, ()>
  39:     0x7fb4bed25a5f - rustc_query_system[5961241f39e0d58f]::query::plumbing::try_execute_query::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt, rustc_query_system[5961241f39e0d58f]::query::caches::DefaultCache<rustc_span[18a919f8c0850d33]::def_id::LocalDefId, ()>>
  40:     0x7fb4bedf41c4 - rustc_query_system[5961241f39e0d58f]::query::plumbing::get_query::<rustc_query_impl[b30ae0b18ffa5f8d]::queries::collect_mod_item_types, rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt>
  41:     0x7fb4bec74f7d - <rustc_query_impl[b30ae0b18ffa5f8d]::Queries as rustc_middle[5d1ff1ffbdb84c71]::ty::query::QueryEngine>::collect_mod_item_types
  42:     0x7fb4be352887 - <rustc_middle[5d1ff1ffbdb84c71]::hir::map::Map>::for_each_module::<rustc_typeck[2b53629f01fad2c1]::check_crate::{closure#0}::{closure#0}::{closure#0}>
  43:     0x7fb4be332772 - <rustc_session[5fd84be164c87cb9]::session::Session>::track_errors::<rustc_typeck[2b53629f01fad2c1]::check_crate::{closure#0}, ()>
  44:     0x7fb4be0ff441 - rustc_typeck[2b53629f01fad2c1]::check_crate
  45:     0x7fb4bda432a1 - rustc_interface[a80cab810099d0cd]::passes::analysis
  46:     0x7fb4bee409f4 - <rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind as rustc_query_system[5961241f39e0d58f]::dep_graph::DepKind>::with_deps::<<rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle[5d1ff1ffbdb84c71]::ty::context::TyCtxt, (), core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>::{closure#0}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>
  47:     0x7fb4bef8597a - <rustc_query_system[5961241f39e0d58f]::dep_graph::graph::DepGraph<rustc_middle[5d1ff1ffbdb84c71]::dep_graph::dep_node::DepKind>>::with_task::<rustc_middle[5d1ff1ffbdb84c71]::ty::context::TyCtxt, (), core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>
  48:     0x7fb4bed5a157 - rustc_query_system[5961241f39e0d58f]::query::plumbing::try_execute_query::<rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt, rustc_query_system[5961241f39e0d58f]::query::caches::DefaultCache<(), core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>>
  49:     0x7fb4bee1ce42 - rustc_query_system[5961241f39e0d58f]::query::plumbing::get_query::<rustc_query_impl[b30ae0b18ffa5f8d]::queries::analysis, rustc_query_impl[b30ae0b18ffa5f8d]::plumbing::QueryCtxt>
  50:     0x7fb4bec5fa72 - <rustc_query_impl[b30ae0b18ffa5f8d]::Queries as rustc_middle[5d1ff1ffbdb84c71]::ty::query::QueryEngine>::analysis
  51:     0x7fb4bd95a724 - <rustc_interface[a80cab810099d0cd]::passes::QueryContext>::enter::<rustc_driver[a177c53ac2cf0051]::run_compiler::{closure#1}::{closure#2}::{closure#3}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>
  52:     0x7fb4bd955e18 - <rustc_interface[a80cab810099d0cd]::interface::Compiler>::enter::<rustc_driver[a177c53ac2cf0051]::run_compiler::{closure#1}::{closure#2}, core[5571ea7c97e175b]::result::Result<core[5571ea7c97e175b]::option::Option<rustc_interface[a80cab810099d0cd]::queries::Linker>, rustc_errors[c08561276749af2a]::ErrorGuaranteed>>
  53:     0x7fb4bd9666a7 - rustc_span[18a919f8c0850d33]::with_source_map::<core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>, rustc_interface[a80cab810099d0cd]::interface::create_compiler_and_run<core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>, rustc_driver[a177c53ac2cf0051]::run_compiler::{closure#1}>::{closure#1}>
  54:     0x7fb4bd956993 - rustc_interface[a80cab810099d0cd]::interface::create_compiler_and_run::<core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>, rustc_driver[a177c53ac2cf0051]::run_compiler::{closure#1}>
  55:     0x7fb4bd969bf2 - <scoped_tls[cbbb43b5eb84c7ca]::ScopedKey<rustc_span[18a919f8c0850d33]::SessionGlobals>>::set::<rustc_interface[a80cab810099d0cd]::interface::run_compiler<core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>, rustc_driver[a177c53ac2cf0051]::run_compiler::{closure#1}>::{closure#0}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>
  56:     0x7fb4bd9003c9 - std[a2c7089b4b8c7571]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[a80cab810099d0cd]::util::run_in_thread_pool_with_globals<rustc_interface[a80cab810099d0cd]::interface::run_compiler<core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>, rustc_driver[a177c53ac2cf0051]::run_compiler::{closure#1}>::{closure#0}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>::{closure#0}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>
  57:     0x7fb4bd8ff45e - std[a2c7089b4b8c7571]::panicking::try::<core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>, core[5571ea7c97e175b]::panic::unwind_safe::AssertUnwindSafe<<std[a2c7089b4b8c7571]::thread::Builder>::spawn_unchecked_<rustc_interface[a80cab810099d0cd]::util::run_in_thread_pool_with_globals<rustc_interface[a80cab810099d0cd]::interface::run_compiler<core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>, rustc_driver[a177c53ac2cf0051]::run_compiler::{closure#1}>::{closure#0}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>::{closure#0}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>::{closure#1}::{closure#0}>>
  58:     0x7fb4bd953db0 - <<std[a2c7089b4b8c7571]::thread::Builder>::spawn_unchecked_<rustc_interface[a80cab810099d0cd]::util::run_in_thread_pool_with_globals<rustc_interface[a80cab810099d0cd]::interface::run_compiler<core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>, rustc_driver[a177c53ac2cf0051]::run_compiler::{closure#1}>::{closure#0}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>::{closure#0}, core[5571ea7c97e175b]::result::Result<(), rustc_errors[c08561276749af2a]::ErrorGuaranteed>>::{closure#1} as core[5571ea7c97e175b]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  59:     0x7fb4bd02d5a8 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h6bef02aba93c72af
  60:     0x7fb4bd068cb7 - std::sys::unix::thread::Thread::new::thread_start::hc79df79faa940a35
  61:     0x7fb4b7baffa3 - start_thread
                               at /build/glibc-fWwxX8/glibc-2.28/nptl/pthread_create.c:486:8
  62:     0x7fb4bceedeff - clone
                               at /build/glibc-fWwxX8/glibc-2.28/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95
  63:                0x0 - <unknown>

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.64.0-dev running on x86_64-unknown-linux-gnu

note: compiler flags: --crate-type bin -C embed-bitcode=no -C debuginfo=2 -C incremental

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [late_bound_vars_map] looking up late bound vars
#1 [explicit_predicates_of] computing explicit predicates of `_call`
#2 [collect_mod_item_types] collecting item types in top-level module
#3 [analysis] running analysis passes on this crate
end of query stack
error: could not compile `research` due to previous error

Signed-off-by: Yuki Okushi <jtitor@2k36.org>

Rustup to rust-lang/rust#95884 Fixes #337 Signed-off-by: Yuki Okushi <jtitor@2k36.org>

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 10, 2022

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 11, 2022

cjgillot force-pushed the assoc-item branch from fcd2f9b to b17e949 Compare July 30, 2022 14:37

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 30, 2022

This comment has been minimized.

Sign in to view

cjgillot force-pushed the assoc-item branch from b17e949 to 09a25c3 Compare July 30, 2022 15:17

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 30, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 1, 2022

cjgillot added 6 commits August 1, 2022 21:38

Store associated item defaultness in impl_defaultness.

110f065

Remove visibility from AssocItem.

8ee4446

Remove DefId from AssocItemContainer.

d7ea161

Remove trait_of_item query.

9575481

Bless incremental tests.

6c5f077

Match on TraitItem exhaustively.

212a06e

cjgillot force-pushed the assoc-item branch from 56c85c0 to 212a06e Compare August 1, 2022 19:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2022

bors merged commit 21de280 into rust-lang:master Aug 2, 2022

rustbot added this to the 1.64.0 milestone Aug 2, 2022

bors mentioned this pull request Aug 2, 2022

Use niche-filling optimization even when multiple variants have data. #94075

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 2, 2022

cjgillot deleted the assoc-item branch August 2, 2022 16:32

JohnTitor added a commit to JohnTitor/rust-semverver that referenced this pull request Aug 3, 2022

Rustup to rust-lang/rust#95884

678729a

Signed-off-by: Yuki Okushi <jtitor@2k36.org>

bors added a commit to rust-lang/rust-semverver that referenced this pull request Aug 4, 2022

Auto merge of #338 - JohnTitor:rustup-2022-08-03, r=JohnTitor

4a22c94

Rustup to rust-lang/rust#95884 Fixes #337 Signed-off-by: Yuki Okushi <jtitor@2k36.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Thin `AssocItem` #95884

Thin `AssocItem` #95884

cjgillot commented Apr 10, 2022 •

edited

Loading

This comment has been minimized.

bors commented Apr 11, 2022

cjgillot commented Jul 30, 2022

rust-timer commented Jul 30, 2022

bors commented Jul 30, 2022

This comment has been minimized.

bors commented Jul 30, 2022

This comment has been minimized.

cjgillot commented Jul 30, 2022

rust-timer commented Jul 30, 2022

bors commented Jul 30, 2022

This comment has been minimized.

cjgillot commented Jul 30, 2022

rust-timer commented Jul 30, 2022

bors commented Jul 30, 2022

bors commented Jul 30, 2022

rust-timer commented Jul 30, 2022

rust-timer commented Jul 30, 2022

bors commented Aug 1, 2022

bors commented Aug 1, 2022

cjgillot commented Aug 1, 2022

bors commented Aug 1, 2022

bors commented Aug 1, 2022

bors commented Aug 2, 2022

rust-timer commented Aug 2, 2022

nnethercote commented Aug 2, 2022

ethe commented Aug 2, 2022 •

edited

Loading

Thin AssocItem #95884

Thin AssocItem #95884

Conversation

cjgillot commented Apr 10, 2022 • edited Loading

This comment has been minimized.

bors commented Apr 11, 2022

cjgillot commented Jul 30, 2022

rust-timer commented Jul 30, 2022

bors commented Jul 30, 2022

This comment has been minimized.

bors commented Jul 30, 2022

This comment has been minimized.

cjgillot commented Jul 30, 2022

rust-timer commented Jul 30, 2022

bors commented Jul 30, 2022

This comment has been minimized.

cjgillot commented Jul 30, 2022

rust-timer commented Jul 30, 2022

bors commented Jul 30, 2022

bors commented Jul 30, 2022

rust-timer commented Jul 30, 2022

rust-timer commented Jul 30, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

bors commented Aug 1, 2022

bors commented Aug 1, 2022

cjgillot commented Aug 1, 2022

bors commented Aug 1, 2022

bors commented Aug 1, 2022

bors commented Aug 2, 2022

rust-timer commented Aug 2, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

nnethercote commented Aug 2, 2022

ethe commented Aug 2, 2022 • edited Loading

Thin `AssocItem` #95884

Thin `AssocItem` #95884

cjgillot commented Apr 10, 2022 •

edited

Loading

ethe commented Aug 2, 2022 •

edited

Loading