Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require all paths passed to ShouldRun::paths to exist on disk #95906

Merged
merged 1 commit into from
Apr 18, 2022

Commits on Apr 16, 2022

  1. Require all paths passed to ShouldRun::paths to exist on disk

    This has two benefits:
    1. There is a clearer mental model of how bootstrap works. Steps correspond to paths on disk unless it's strictly impossible for them to do so (e.g. dist components).
    2. Bootstrap has better checks for internal consistency. This caught several issues:
      - `src/sanitizers` doesn't exist; I changed it to just be a `sanitizers` alias.
      - `src/tools/lld` doesn't exist; I removed it, since `lld` alone already works.
      - `src/llvm` doesn't exist; removed it since `llvm` and `src/llvm-project` both work.
      - `src/lldb_batchmode.py` doesn't exist, it was moved to `src/etc`.
      - `install` was still using `src/librustc` instead of `compiler/rustc`.
      - None of the tools in `dist` / `install` allowed using `src/tools/X` to build them. This might be intentional - I can change them to aliases if you like.
    jyn514 committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    0db70ca View commit details
    Browse the repository at this point in the history