Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Borrow and BorrowMut for Vecs with Allocators #95929

Closed
wants to merge 1 commit into from
Closed

Implement Borrow and BorrowMut for Vecs with Allocators #95929

wants to merge 1 commit into from

Conversation

SparkyPotato
Copy link
Contributor

Implemented Borrow and BorrowMut for all Vecs, not just Vec<T, Global>.

@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2022
@SparkyPotato
Copy link
Contributor Author

@m-ou-se mind taking a look? :)

@apiraino apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 23, 2022
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2022
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2022
@the8472 the8472 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 12, 2022
@the8472
Copy link
Member

the8472 commented Nov 12, 2022

This looks fine but since it technically is an instant-stable API change I think this needs an FCP.

@thomcc
Copy link
Member

thomcc commented Nov 12, 2022

Is it insta-stable given that Allocator isn't stable?

@the8472
Copy link
Member

the8472 commented Nov 12, 2022

Oh, you're right.

Also, this has already been implemented in #99317 (docs link). Somhow github still shows a non-empty diff.

I think we can close this then.

@the8472 the8472 added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Nov 12, 2022
@the8472 the8472 closed this Nov 12, 2022
@SparkyPotato SparkyPotato deleted the vec-borrow-with-alloc branch June 24, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SparkyPotato @rust-highfive @the8472 @thomcc @m-ou-se @JohnCSimon @apiraino