-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followups for method call error change #96155
Conversation
☔ The latest upstream changes (presumably #96663) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clearly separated commits and apologies for the delay. r=me after addressing nitpicks and rebasing.
6e86c78
to
e237e78
Compare
It seems you have to rebase again 😅 |
Yeah. I had to step away from my computer before I was actually able to rebase (just made the review changes). |
e237e78
to
abde236
Compare
abde236
to
7d8e10d
Compare
@bors r=estebank |
📌 Commit 7d8e10d has been approved by |
… r=estebank Followups for method call error change Each commit is self-contained. Fixes most of the followup reviews from that PR. r? `@estebank`
⌛ Testing commit 7d8e10d with merge baf9b0e83903681ab8324b1286ef1cd30217c5aa... |
☀️ Test successful - checks-actions |
Finished benchmarking commit (030c886): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Each commit is self-contained. Fixes most of the followup reviews from that PR.
r? @estebank