Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: index out of bound on empty comment #96204

Closed
wants to merge 1 commit into from
Closed

fix: index out of bound on empty comment #96204

wants to merge 1 commit into from

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented Apr 19, 2022

Closes #96201

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 19, 2022
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2022
@jbr
Copy link
Contributor

jbr commented Apr 19, 2022

Well that's embarrassing, I didn't intend to check in an empty doc comment

@notriddle
Copy link
Contributor

Can you put together a regression test for this?

@csmoe
Copy link
Member Author

csmoe commented Apr 21, 2022

Already fixed in #95800

@csmoe csmoe closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: 'index out of bounds: the len is 0 but the index is 0', compiler/rustc_ast/src/util/comments.rs:55:28
6 participants
@csmoe @rust-highfive @jbr @notriddle @estebank @rustbot