-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Optimize const_prop
mir-opt by writing the layouts to ext
#96213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
r? @oli-obk (as suggested by github) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 2fb2960 with merge 5577c9a78853cb76c76e642a7d972afa992a0b22... |
☀️ Try build successful - checks-actions |
Queued 5577c9a78853cb76c76e642a7d972afa992a0b22 with parent c102c5c, future comparison URL. |
Finished benchmarking commit (5577c9a78853cb76c76e642a7d972afa992a0b22): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Footnotes |
It seems that writing layouts of locals into |
Yea, that sounds reasonable |
Optimize `const_prop` mir-opt by accessing `local_decls` through `ecx` From the FIXME in the impl of `ConstPropagator`. Accessing `local_decls` and `scource_scopes` from `ecx` can reduce `clone` calls and save compile time. Besides, according to rust-lang#96213 , the FIXME about writing `layouts` to `ecx` in advance can also be removed.
From the FIXME in the
const_prop
mir-opt.Write layouts of locals to
ext
in advance, which should reduce the invocation oflayout_of
query and thus reduce compilation time.