-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Resolve some more doc links early #96261
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit e0b71ff with merge bd0e0e462384317dff100d42939285d5a16e4e9b... |
☀️ Try build successful - checks-actions |
Queued bd0e0e462384317dff100d42939285d5a16e4e9b with parent 51ea9bb, future comparison URL. |
Finished benchmarking commit (bd0e0e462384317dff100d42939285d5a16e4e9b): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Footnotes |
|
Does it fix the missing call to |
No, I'll submit that change later. Let's actually land this, it's a pure performance win, and a relatively large one, and I won't be able to work on other parts of #94857 until the next week. |
Thanks! I prefer to keep perf improvements merged on their own so we can track them more efficiently. @bors r+ rollup=never |
📌 Commit e0b71ff has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0b3404b): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Trying another subset of #94857 that is not too expensive.