-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incremental perf regression unsafety checking #96425
Fix incremental perf regression unsafety checking #96425
Conversation
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4882b70768c6cc0ce49490d707cd159b2b5fc304 with merge 83858ee454a76d4e8b12d9299824b9054609b99d... |
src/test/ui/async-await/async-unsafe-fn-call-in-safe.thir.stderr
Outdated
Show resolved
Hide resolved
☀️ Try build successful - checks-actions |
Queued 83858ee454a76d4e8b12d9299824b9054609b99d with parent d6a57d3, future comparison URL. |
Finished benchmarking commit (83858ee454a76d4e8b12d9299824b9054609b99d): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
…in E0133" This reverts commit 8b8f665.
4882b70
to
3568bdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will simply avoid emitting the name of the unsafe function in MIR unsafeck, since we're moving to THIR unsafeck anyway.
I think this change is reasonable, since the highlighted span elucidates the call anyways.
r? @compiler-errors |
📌 Commit 3568bdc has been approved by |
This comment was marked as duplicate.
This comment was marked as duplicate.
☀️ Test successful - checks-actions |
Finished benchmarking commit (a719718): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Perf regression introduced in #96294
We will simply avoid emitting the name of the unsafe function in MIR unsafeck, since we're moving to THIR unsafeck anyway.