Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incremental perf regression unsafety checking #96425

Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 26, 2022

Perf regression introduced in #96294

We will simply avoid emitting the name of the unsafe function in MIR unsafeck, since we're moving to THIR unsafeck anyway.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 26, 2022
@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 26, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 26, 2022
@bors
Copy link
Contributor

bors commented Apr 26, 2022

⌛ Trying commit 4882b70768c6cc0ce49490d707cd159b2b5fc304 with merge 83858ee454a76d4e8b12d9299824b9054609b99d...

@bors
Copy link
Contributor

bors commented Apr 26, 2022

☀️ Try build successful - checks-actions
Build commit: 83858ee454a76d4e8b12d9299824b9054609b99d (83858ee454a76d4e8b12d9299824b9054609b99d)

@rust-timer
Copy link
Collaborator

Queued 83858ee454a76d4e8b12d9299824b9054609b99d with parent d6a57d3, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (83858ee454a76d4e8b12d9299824b9054609b99d): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 44 0 44
mean2 N/A N/A -1.3% N/A -1.3%
max N/A N/A -2.9% N/A -2.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 26, 2022
@oli-obk oli-obk force-pushed the fix_incremental_regression_unsafety_checking branch from 4882b70 to 3568bdc Compare April 26, 2022 14:49
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will simply avoid emitting the name of the unsafe function in MIR unsafeck, since we're moving to THIR unsafeck anyway.

I think this change is reasonable, since the highlighted span elucidates the call anyways.

@compiler-errors
Copy link
Member

r? @compiler-errors
@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2022

📌 Commit 3568bdc has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2022
@compiler-errors

This comment was marked as duplicate.

@bors
Copy link
Contributor

bors commented Apr 26, 2022

⌛ Testing commit 3568bdc with merge a719718...

@bors
Copy link
Contributor

bors commented Apr 27, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing a719718 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2022
@bors bors merged commit a719718 into rust-lang:master Apr 27, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 27, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a719718): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 48 0 48
mean2 N/A N/A -1.2% N/A -1.2%
max N/A N/A -2.8% N/A -2.8%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@oli-obk oli-obk deleted the fix_incremental_regression_unsafety_checking branch April 27, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants