Make [e]println macros eagerly drop temporaries (for backport) #96490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rustbot
added
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dtolnay
added
beta-nominated
m-ou-se
added
S-blocked
|
Untagging S-waiting-on-fcp. This is effectively a revert of a small part of #94868. I believe this can safely go in master and beta without waiting on the FCP to expire, to resolve the regression currently affecting beta and make upcoming beta crater runs more useful. If the FCP were to fail (seems unlikely right now from the other thread), we can easily redo the change that this is reverting. |
dtolnay
added
S-waiting-on-review
|
@bors r+ p=1 |
|
📌 Commit 3a8f81a has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added
the
beta-accepted
|
Unilaterally beta-accepting -- seems like a small patch with clear revert results. |
|
⌛ Testing commit 3a8f81a with merge 0fea468750757c429009469d37343e98bfa68eea... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This reverts commit ac5c657.
|
@bors r=Mark-Simulacrum |
|
📌 Commit e2d4c7b has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (61469b6): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
ehuss
pushed a commit
to ehuss/rust
that referenced
this pull request
May 4, 2022
…lacrum Make [e]println macros eagerly drop temporaries (for backport) This PR extracts the subset of rust-lang#96455 which is only the parts necessary for fixing the 1.61-beta regressions in rust-lang#96434. My larger PR rust-lang#96455 contains a few other changes relative to the pre-rust-lang#94868 behavior; those are not necessary to backport into 1.61. argument position | before rust-lang#94868 | after rust-lang#94868 | after this PR --- |:---:|:---:|:---: `write!($tmp, "…", …)` | :rage: | :rage: | :rage: `write!(…, "…", $tmp)` | :rage: | :rage: | :rage: `writeln!($tmp, "…", …)` | :rage: | :rage: | :rage: `writeln!(…, "…", $tmp)` | :rage: | :rage: | :rage: `print!("…", $tmp)` | :rage: | :rage: | :rage: `println!("…", $tmp)` | :smiley_cat: | :rage: | :smiley_cat: `eprint!("…", $tmp)` | :rage: | :rage: | :rage: `eprintln!("…", $tmp)` | :smiley_cat: | :rage: | :smiley_cat: `panic!("…", $tmp)` | :smiley_cat: | :smiley_cat: | :smiley_cat:
Merged
ehuss
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2022
[beta] Beta backports * Revert diagnostic duplication and accidental stabilization rust-lang#96516 * Revert "Re-export core::ffi types from std::ffi" rust-lang#96492 * Make [e]println macros eagerly drop temporaries (for backport) rust-lang#96490 * Revert "impl From<&[T; N]> and From<&mut [T; N]> for Vec<T>" rust-lang#96489 * Cargo: * move workspace inheritance unstable docs to the correct place (rust-lang/cargo#10616)
RalfJung
reviewed
May 8, 2022
| ($($arg:tt)*) => { | ||
| $crate::io::_print($crate::format_args_nl!($($arg)*)) | ||
| }; | ||
| ($($arg:tt)*) => {{ |
There was a problem hiding this comment.
Given the back and forth here, it might be worth adding a comment that explains why a double brace is used?
MabezDev
pushed a commit
to esp-rs/rust
that referenced
this pull request
May 17, 2022
…lacrum Make [e]println macros eagerly drop temporaries (for backport) This PR extracts the subset of rust-lang#96455 which is only the parts necessary for fixing the 1.61-beta regressions in rust-lang#96434. My larger PR rust-lang#96455 contains a few other changes relative to the pre-rust-lang#94868 behavior; those are not necessary to backport into 1.61. argument position | before rust-lang#94868 | after rust-lang#94868 | after this PR --- |:---:|:---:|:---: `write!($tmp, "…", …)` | :rage: | :rage: | :rage: `write!(…, "…", $tmp)` | :rage: | :rage: | :rage: `writeln!($tmp, "…", …)` | :rage: | :rage: | :rage: `writeln!(…, "…", $tmp)` | :rage: | :rage: | :rage: `print!("…", $tmp)` | :rage: | :rage: | :rage: `println!("…", $tmp)` | :smiley_cat: | :rage: | :smiley_cat: `eprint!("…", $tmp)` | :rage: | :rage: | :rage: `eprintln!("…", $tmp)` | :smiley_cat: | :rage: | :smiley_cat: `panic!("…", $tmp)` | :smiley_cat: | :smiley_cat: | :smiley_cat:
dtolnay
added
T-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the subset of #96455 which is only the parts necessary for fixing the 1.61-beta regressions in #96434.
My larger PR #96455 contains a few other changes relative to the pre-#94868 behavior; those are not necessary to backport into 1.61.
write!($tmp, "…", …)write!(…, "…", $tmp)writeln!($tmp, "…", …)writeln!(…, "…", $tmp)print!("…", $tmp)println!("…", $tmp)eprint!("…", $tmp)eprintln!("…", $tmp)panic!("…", $tmp)