Skip to content

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Apr 28, 2022

This new enum entry was introduced in https://reviews.llvm.org/D122268,
and if I'm reading correctly there's no case where we'd ever encounter
it in our uses of LLVM. To preserve the ability to compile this file
with -Werror -Wswitch we add an explicit case for this entry.

r? nikic

This new enum entry was introduced in https://reviews.llvm.org/D122268,
and if I'm reading correctly there's no case where we'd ever encounter
it in our uses of LLVM. To preserve the ability to compile this file
with -Werror -Wswitch we add an explicit case for this entry.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 28, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2022
@durin42
Copy link
Contributor Author

durin42 commented Apr 28, 2022

r? @nikic

@rust-highfive rust-highfive assigned nikic and unassigned wesleywiser Apr 28, 2022
@nikic
Copy link
Contributor

nikic commented Apr 28, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 28, 2022

📌 Commit e8ae06a has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96390 (Switch JS code to ES6 - part 2)
 - rust-lang#96527 (RustWrapper: explicitly don't handle DXILPointerTyID)
 - rust-lang#96536 (rustdoc: fix missing method list for primitive deref target)
 - rust-lang#96559 (Use the correct lifetime binder for elided lifetimes in path.)
 - rust-lang#96560 (Remove unnecessary environment variable in cf-protection documentation)
 - rust-lang#96562 (Fix duplicate directory separator in --remap-path-prefix.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 041f3b6 into rust-lang:master Apr 30, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 30, 2022
@durin42 durin42 deleted the llvm-15-werror-wswitch branch May 11, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants