Render all trait bounds in where clauses in rustdoc

[cjgillot]

Split from #93803.

This PR modifies the rendering of bounds on generic parameters in rustdoc.

fn foo<T: Default, U>(x: impl Copy) where U: Clone

into

fn foo<T, U>(x: impl Copy) where T: Default, U: Clone

r? @GuillaumeGomez

[rust-highfive]

Some changes occurred in clean/types.rs.

cc @camelid

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider,@aDotInTheVoid

[GuillaumeGomez]

Thanks for opening it!

So the zulip discussion about this is happening here.

[aDotInTheVoid]

Regardless of what gets decided for the HTML, I think this would be great for JSON.

[Enselic]

My public API diffing and listing tool is based on rustdoc JSON and tries to represent items the same way as the HTML, to minimize user confusion. So if we only change this in rustdoc JSON, that use case can't be fulfilled any longer. So my preference would be to keep HTML and JSON in sync in this regard.

[bors]

☔ The latest upstream changes (presumably #96816) made this pull request unmergeable. Please resolve the merge conflicts.

[JohnCSimon]

triage: returning to @cjgillot to address merge conflicts
@rustbot author

[rust-log-analyzer]

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [js-doc-test] src/test/rustdoc-js/generics-impl.rs stdout ----

error: rustdoc-js test failed!
status: exit status: 1
command: "/usr/bin/node" "/checkout/src/tools/rustdoc-js/tester.js" "--doc-folder" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-js/generics-impl" "--crate-name" "generics_impl" "--test-file" "/checkout/src/test/rustdoc-js/generics-impl.js"
Testing /checkout/src/test/rustdoc-js/generics-impl.js ... FAILED
Testing /checkout/src/test/rustdoc-js/generics-impl.js ... FAILED
[ query `Read -> u64`]==> Expected exactly 2 results but found 0 in 'others'
[ query `Read -> u64`]==> Result not found in 'others': '{"path":"generics_impl::Ddddddd","name":"eeeeeee"}'
Diff of first error:
 {
-     "path": "generics_impl::Ddddddd",
-     "name": "eeeeeee",
 }
[ query `Read -> u64`]==> Result not found in 'others': '{"path":"generics_impl::Ddddddd","name":"ggggggg"}'
Diff of first error:
 {
-     "path": "generics_impl::Ddddddd",
-     "name": "ggggggg",
------------------------------------------
stderr: none

[cjgillot]

I did not follow the zulip discussions. @GuillaumeGomez is the rustdoc team interested in landing this change, or should I close the PR?

[GuillaumeGomez]

There doesn't seem to have a consensus based on what I can see from the zulip discussion. :-/

[bors]

☔ The latest upstream changes (presumably #98279) made this pull request unmergeable. Please resolve the merge conflicts.

[cjgillot]

I'm closing this PR. Please don't hesitate to ping me or pick it up if the consensus evolves.