-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #96734
Rollup of 7 pull requests #96734
Conversation
…e of other errors
do not suggest when trait_ref is some Update compiler/rustc_resolve/src/late/diagnostics.rs Co-authored-by: lcnr <rust@lcnr.de> use helper struct add a test for functions with some params refactor debug log
Update `int_roundings` methods from feedback This updates `#![feature(int_roundings)]` (rust-lang#88581) from feedback. All methods now take `NonZeroX`. The documentation makes clear that they panic in debug mode and wrap in release mode. r? `@joshtriplett` `@rustbot` label +T-libs +T-libs-api +S-waiting-on-review
…oc, r=m-ou-se Improve Rc::new_cyclic and Arc::new_cyclic documentation Fixes rust-lang#95672. cc `@CAD97` (since I used your explanations)
…function, r=lcnr Suggest calling `Self::associated_function()` closes rust-lang#96453
…triddle Use "strict" mode in JS scripts Part of rust-lang#93058. r? `@notriddle`
…rochenkov Report that opaque types are not allowed in impls even in the presence of other errors fixes rust-lang#96569 before this PR those useful errors were hidden because either `unused parameter` or `only traits defined in the current crate can be implemented for arbitrary types` got emitted first.
…r=petrochenkov Show invisible delimeters (within comments) when pretty printing. Because invisible syntax is really hard to work with! r? `@petrochenkov`
interpret/validity: debug-check ScalarPair layout information This would have caught rust-lang#96158. I ran the Miri test suite and it still passes. r? `@oli-obk`
@bors r+ rollup=never p=7 |
📌 Commit 6804819 has been approved by |
⌛ Testing commit 6804819 with merge 8a53faa59e2022e9b3829e49f7f5b35aaaeaa61c... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Test successful - checks-actions |
Finished benchmarking commit (50cf76c): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Successful merges:
int_roundings
methods from feedback #95359 (Updateint_roundings
methods from feedback)Self::associated_function()
#96507 (Suggest callingSelf::associated_function()
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup