Track if a where bound comes from a impl Trait desugar #96770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bb01aca. Partial: Keep regression tests
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
cjgillot
reviewed
May 6, 2022
cjgillot
reviewed
May 6, 2022
cjgillot
added
S-waiting-on-author
|
r=me after addressing cjgillot's comment |
flip1995
force-pushed
the
fix-trait-type-in-bounds
branch
from
bfa15d6 to
65e38fa
Compare
With rust-lang#93803 `impl Trait` function arguments get desugared to hidden where bounds. However, Clippy needs to know if a bound was originally a impl Trait or an actual bound. This adds a field to the `WhereBoundPredicate` struct to keep track of this information during HIR lowering.
flip1995
force-pushed
the
fix-trait-type-in-bounds
branch
from
65e38fa to
dd1ff40
Compare
|
I think I addressed everything. |
|
@bors r+ |
|
📌 Commit dd1ff40 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ed3164b): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
xFrednet
pushed a commit
to xFrednet/rust
that referenced
this pull request
May 21, 2022
…cjgillot Track if a where bound comes from a impl Trait desugar With rust-lang#93803 `impl Trait` function arguments get desugared to hidden where bounds. However, Clippy needs to know if a bound was originally a `impl Trait` or an actual bound. This adds a field to the `WhereBoundPredicate` struct to keep track of this information during AST->HIR lowering. r? `@cjgillot` cc `@estebank` (as the reviewer of rust-lang#93803)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #93803
impl Traitfunction arguments get desugared to hidden where bounds. However, Clippy needs to know if a bound was originally aimpl Traitor an actual bound. This adds a field to theWhereBoundPredicatestruct to keep track of this information during AST->HIR lowering.r? @cjgillot
cc @estebank (as the reviewer of #93803)