Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Make sys::windows::os_str::Slice repr(transparent) #96802

Merged
merged 2 commits into from
May 9, 2022
Merged

[feat] Make sys::windows::os_str::Slice repr(transparent) #96802

merged 2 commits into from
May 9, 2022

Conversation

gimbling-away
Copy link
Contributor

Fixes #96577

@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 7, 2022
@rust-highfive
Copy link
Collaborator

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2022
@gimbling-away gimbling-away marked this pull request as draft May 7, 2022 03:50
@gimbling-away gimbling-away marked this pull request as ready for review May 7, 2022 05:15
@ChrisDenton
Copy link
Member

Looks ok to me. The sys modules are private so this shouldn't affect the public API. But if you did want to fix the error in your first commit then you could try adding pub(crate) to both Buf and Slice.

@thomcc
Copy link
Member

thomcc commented May 8, 2022

Seems fine.

@bors r+

@bors
Copy link
Contributor

bors commented May 8, 2022

📌 Commit 3b5fe26 has been approved by thomcc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2022
@bors
Copy link
Contributor

bors commented May 9, 2022

⌛ Testing commit 3b5fe26 with merge db5b365...

@bors
Copy link
Contributor

bors commented May 9, 2022

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing db5b365 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2022
@bors bors merged commit db5b365 into rust-lang:master May 9, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 9, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (db5b365): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@gimbling-away gimbling-away deleted the windows_slice branch May 10, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[repr(transparent)] in sys::windows::os_str::Slice
7 participants