Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js error #96900

Merged
merged 3 commits into from
May 11, 2022
Merged

Fix js error #96900

merged 3 commits into from
May 11, 2022

Conversation

GuillaumeGomez
Copy link
Member

On the source code pages, we get a JS error:

Screenshot from 2022-05-10 16-26-53

It's fixed in the first commit. The second one is removing an unused CSS rule and the third one is a little cleanup of a GUI test.

cc @jsha
r? @notriddle

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-doctests Area: Documentation tests, run by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) A-rustdoc-js Area: Rustdoc's JS front-end labels May 10, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022
@GuillaumeGomez
Copy link
Member Author

I opened #96902 about adding a check for JS errors.

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2022

📌 Commit fe4fa53 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 10, 2022
…iddle

Fix js error

On the source code pages, we get a JS error:

![Screenshot from 2022-05-10 16-26-53](https://user-images.githubusercontent.com/3050060/167656292-51e0b0e9-6b0c-4f94-82e0-dd8fb77adf52.png)

It's fixed in the first commit. The second one is removing an unused CSS rule and the third one is a little cleanup of a GUI test.

cc `@jsha`
r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#96543 (Remove hacks in `make_token_stream`.)
 - rust-lang#96887 (rustdoc: correct path to type alias methods)
 - rust-lang#96896 (Add regression test for rust-lang#68408)
 - rust-lang#96900 (Fix js error)
 - rust-lang#96903 (Use lifetimes on type-alias-impl-trait used in function signatures to infer output type lifetimes)
 - rust-lang#96916 (simplify length count)
 - rust-lang#96925 (Fix issue rust-lang#95151)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 95b2d37 into rust-lang:master May 11, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 11, 2022
@GuillaumeGomez GuillaumeGomez deleted the fix-js-error branch May 11, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-doctests Area: Documentation tests, run by rustdoc A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants