Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update graphviz links #96941

Merged
merged 1 commit into from
May 12, 2022
Merged

update graphviz links #96941

merged 1 commit into from
May 12, 2022

Conversation

nannany
Copy link
Contributor

@nannany nannany commented May 11, 2022

Update graphviz links.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 11, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2022
JohnTitor
JohnTitor reviewed May 11, 2022
View reviewed changes
compiler/rustc_graphviz/src/lib.rs Outdated
@@ -1,21 +1,19 @@
//! Generate files suitable for use with [Graphviz](https://www.graphviz.org/)
//! Generate files suitable for use with [Graphviz](https://graphviz.org/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change? I don't think it's necessary to fix the links below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not particular about adding "www" or not, so I changed it according to your policy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, unrelated diffs make it unobvious what's changed and fixed. From that point of view, I didn't request to add subdomains but remove these diffs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it'd be great if you could squash commits once it's done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your advice.
And I squashed commits.

@nannany
update graphviz links
2c604f6 
add subdomain
@lcnr
Copy link
Contributor

lcnr commented May 12, 2022

thanks

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 12, 2022

📌 Commit 2c604f6 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2022
@lcnr
Copy link
Contributor

lcnr commented May 12, 2022

@bors r-

@bors r=lcnr,JohnTitor

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 12, 2022
@bors
Copy link
Contributor

bors commented May 12, 2022

📌 Commit 2c604f6 has been approved by lcnr,JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request May 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2022
@bors
Auto merge of rust-lang#96974 - matthiaskrgr:rollup-jd4otnc, r=matthi…
c6499fd 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#95896 (Note the contacts for the nvptx64 target(s))
 - rust-lang#96860 (openbsd: convert futex timeout managment to Timespec usage)
 - rust-lang#96939 (Fix settings page CSS)
 - rust-lang#96941 (update graphviz links)
 - rust-lang#96968 (Add tests for rust-lang#96806)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 47e4c9e into rust-lang:master May 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nannany @rust-highfive @lcnr @bors @JohnTitor @rustbot