-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #96994
Rollup of 6 pull requests #96994
Commits on Apr 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5765819 - Browse repository at this point
Copy the full SHA 5765819View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f10c0a - Browse repository at this point
Copy the full SHA 6f10c0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a03f15a - Browse repository at this point
Copy the full SHA a03f15aView commit details
Commits on May 10, 2022
-
libtest already supports a "--skip SUBSTRING" arg which excludes any test names matching SUBSTRING. This adds a "--skip" argument to compiletest and bootstrap which is forwarded to libtest.
Configuration menu - View commit details
-
Copy full SHA for b2316c1 - Browse repository at this point
Copy the full SHA b2316c1View commit details
Commits on May 11, 2022
-
Clarify what values
BorrowedHandle
,OwnedHandle
etc. can hold.Clarify that when `BorrowedHandle`, `OwnedHandle`, or `HandleOrNull` hold the value `-1`, it always means the current process handle, and not `INVALID_HANDLE_VALUE`.
Configuration menu - View commit details
-
Copy full SHA for 4ce68c1 - Browse repository at this point
Copy the full SHA 4ce68c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bb7fdb - Browse repository at this point
Copy the full SHA 2bb7fdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a39e5a - Browse repository at this point
Copy the full SHA 0a39e5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f75b4a - Browse repository at this point
Copy the full SHA 2f75b4aView commit details -
Add test of matches macro for trailing commas
ludfo774 authoredMay 11, 2022 Configuration menu - View commit details
-
Copy full SHA for cdbfd3e - Browse repository at this point
Copy the full SHA cdbfd3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c586bc3 - Browse repository at this point
Copy the full SHA c586bc3View commit details
Commits on May 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 516a7fa - Browse repository at this point
Copy the full SHA 516a7faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 275812a - Browse repository at this point
Copy the full SHA 275812aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a315bb4 - Browse repository at this point
Copy the full SHA a315bb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3fd6bf - Browse repository at this point
Copy the full SHA d3fd6bfView commit details -
Rollup merge of rust-lang#96455 - dtolnay:writetmp, r=m-ou-se
Make write/print macros eagerly drop temporaries This PR fixes the 2 regressions in rust-lang#96434 (`println` and `eprintln`) and changes all the other similar macros (`write`, `writeln`, `print`, `eprint`) to match the old pre-rust-lang#94868 behavior of `println` and `eprintln`. argument position | before rust-lang#94868 | after rust-lang#94868 | after this PR --- |:---:|:---:|:---: `write!($tmp, "…", …)` | :rage: | :rage: | :smiley_cat: `write!(…, "…", $tmp)` | :rage: | :rage: | :smiley_cat: `writeln!($tmp, "…", …)` | :rage: | :rage: | :smiley_cat: `writeln!(…, "…", $tmp)` | :rage: | :rage: | :smiley_cat: `print!("…", $tmp)` | :rage: | :rage: | :smiley_cat: `println!("…", $tmp)` | :smiley_cat: | :rage: | :smiley_cat: `eprint!("…", $tmp)` | :rage: | :rage: | :smiley_cat: `eprintln!("…", $tmp)` | :smiley_cat: | :rage: | :smiley_cat: `panic!("…", $tmp)` | :smiley_cat: | :smiley_cat: | :smiley_cat: Example of code that is affected by this change: ```rust use std::sync::Mutex; fn main() { let mutex = Mutex::new(0); print!("{}", mutex.lock().unwrap()) /* no semicolon */ } ``` You can see several real-world examples like this in the Crater links at the top of rust-lang#96434. This code failed to compile prior to this PR as follows, but works after this PR. ```console error[E0597]: `mutex` does not live long enough --> src/main.rs:5:18 | 5 | print!("{}", mutex.lock().unwrap()) /* no semicolon */ | ^^^^^^^^^^^^--------- | | | borrowed value does not live long enough | a temporary with access to the borrow is created here ... 6 | } | - | | | `mutex` dropped here while still borrowed | ... and the borrow might be used here, when that temporary is dropped and runs the `Drop` code for type `MutexGuard` ```
Configuration menu - View commit details
-
Copy full SHA for eaf976c - Browse repository at this point
Copy the full SHA eaf976cView commit details -
Rollup merge of rust-lang#96493 - chbaker0:issue-96342-fix, r=Mark-Si…
…mulacrum Add compiletest and bootstrap "--skip" option forwarded to libtest With this PR, "x.py test --skip SKIP ..." will run the specified test suite, but forward "--skip SKIP" to the test tool. libtest already supports this option. The PR also adds it to compiletest which itself just forwards it to libtest. Adds the functionality requested in rust-lang#96342. This is useful to work around tests broken upstream. rust-lang#96362 (comment) is the specific test issue my project is trying to work around.
Configuration menu - View commit details
-
Copy full SHA for c7e56bb - Browse repository at this point
Copy the full SHA c7e56bbView commit details -
Rollup merge of rust-lang#96932 - sunfishcode:sunfishcode/document-bo…
…rrowed-handle, r=joshtriplett Clarify what values `BorrowedHandle`, `OwnedHandle` etc. can hold. Reword the documentation to clarify that when `BorrowedHandle`, `OwnedHandle`, or `HandleOrNull` hold the value `-1`, it always means the current process handle, and not `INVALID_HANDLE_VALUE`. `-1` should only mean `INVALID_HANDLE_VALUE` after a call to a function documented to return that to report errors, which should lead I/O functions to produce errors rather than succeeding and producing `OwnedHandle` or `BorrowedHandle` values. So if a consumer of an `OwnedHandle` or `BorrowedHandle` ever sees them holding a `-1`, it should always mean the current process handle.
Configuration menu - View commit details
-
Copy full SHA for 69581f8 - Browse repository at this point
Copy the full SHA 69581f8View commit details -
Rollup merge of rust-lang#96948 - ludfo774:macro-trailing-comma-test,…
… r=joshtriplett Add test of matches macro for trailing commas Almost all macros are tested for trailing commas. The macro matches! was however not tested. This PR adds that test case. Related to rust-lang#46238
Configuration menu - View commit details
-
Copy full SHA for 77b003d - Browse repository at this point
Copy the full SHA 77b003dView commit details -
Rollup merge of rust-lang#96959 - nbdd0121:unwind, r=Amanieu
Prevent unwinding when `-C panic=abort` is used regardless declared ABI Ensures that Rust code will abort with `-C panic=abort` regardless ABI used. ```rust extern "C-unwind" { fn may_unwind(); } // Will be nounwind with `-C panic=abort`, despite `C-unwind` ABI. pub unsafe extern "C-unwind" fn rust_item_that_can_unwind() { may_unwind(); } ``` Current behaviour is that unwind will propagate through. While the current behaviour won't cause unsoundness it is inconsistent with the text reading of [RFC2945](https://rust-lang.github.io/rfcs/2945-c-unwind-abi.html). I tweaked `fn_can_unwind` instead of tweaking `AbortUnwindingCalls` because this approach would allow Rust (non-direct) callers to also see that this function is nounwind, so it can prevent excessive landing pads generation. For more discussions: https://rust-lang.zulipchat.com/#narrow/stream/210922-project-ffi-unwind/topic/soundness.20in.20mixed.20panic.20mode. cc `@alexcrichton,` `@BatmanAoD` r? `@Amanieu` `@rustbot` label: T-compiler T-lang F-c_unwind
Configuration menu - View commit details
-
Copy full SHA for 8310eb8 - Browse repository at this point
Copy the full SHA 8310eb8View commit details -
Rollup merge of rust-lang#96993 - notriddle:notriddle/prototype, r=Gu…
…illaumeGomez rustdoc: fix GUI crash when searching for magic JS property values
Configuration menu - View commit details
-
Copy full SHA for c5ea430 - Browse repository at this point
Copy the full SHA c5ea430View commit details