-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a query for checking whether a function is an intrinsic. #97012
The head ref may contain hidden characters: "\u{1F980}_intrinsics"
Conversation
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
@bors try @rust-timer queue could have perf effects due to the new query plus changes in how fn_sig is called |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 85132260bf971f7292d93b2ca048ff82b15eb2f5 with merge 6b213e8c965232a466dbe92b778e7c0b868ae89a... |
This comment has been minimized.
This comment has been minimized.
How would this exactly help? Checking the abi works fine, right? |
So the plan was to actually move away from having a separate ABI (at least for compiler intrinsics, we'll see about platform intrinsics). We'll end up with regular Rust functions that backends can opt to either replace with custom logic or just run the pure rust (but likely slower) logic |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 0a6b691 with merge 2c3dcdc0742a2a2bd9c43d4708c30d1612a9d995... |
☀️ Try build successful - checks-actions |
Queued 2c3dcdc0742a2a2bd9c43d4708c30d1612a9d995 with parent 56d540e, future comparison URL. |
Finished benchmarking commit (2c3dcdc0742a2a2bd9c43d4708c30d1612a9d995): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Footnotes |
The stm32f4 regression in cachegrind looks as follows:
|
The regression is pretty much expected. Some overhead will happen when query nodes get dirty and thus recomputed. Since it's overall actually a win, I'm not going to try to change anything. |
Awesome to see work towards #93145! That said, I know nothing about queries and am not a compiler contributor, so I don't think I'm the right person to review. |
@bors r+ |
📌 Commit 0a6b691 has been approved by |
⌛ Testing commit 0a6b691 with merge c90bab9f75c2ec4b9f77efe9304ae809cdbfe904... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors retry timeout |
☀️ Test successful - checks-actions |
Finished benchmarking commit (735efc0): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
@rustbot label: +perf-regression-triaged As per previous analysis #97012 (comment) |
Add a query for checking whether a function is an intrinsic. work towards rust-lang#93145 This will reduce churn when we add more ways to declare intrinsics r? `@scottmcm`
work towards #93145
This will reduce churn when we add more ways to declare intrinsics
r? @scottmcm