-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply PGO to libstd on CI #97038
Apply PGO to libstd on CI #97038
Conversation
@bors try |
⌛ Trying commit db0c826c0c53c91a61454fd37c8958baa2723273 with merge 6f41a1e42d718d175ae4bb9e729b06eb26873b5b... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 0df48dda725feeaf3be4a1a698fa0d168858cce6 with merge 147652c77c95c3eed2fe93aaa1ba74a05f3b5c3c... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
@bors try |
⌛ Trying commit 2cdad2b8e421e62ba7d9be710515a08d7c068b60 with merge f3be0a40a44de01785fb3209225bf31e69337317... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
⌛ Trying commit c5c1b2ed3500d0f1ab959910033ea30d51ca9909 with merge 64f8ccdeb34dfd6cfb01948fd1b348cb0c4d5947... |
☀️ Try build successful - checks-actions |
Queued 64f8ccdeb34dfd6cfb01948fd1b348cb0c4d5947 with parent 56d540e, future comparison URL. |
Finished benchmarking commit (64f8ccdeb34dfd6cfb01948fd1b348cb0c4d5947): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Footnotes |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 1ee57ce with merge 1cb9a96d8ce08c33b68cca0ad459fca5e0de3668... |
☀️ Try build successful - checks-actions |
Queued 1cb9a96d8ce08c33b68cca0ad459fca5e0de3668 with parent a3beeaa, future comparison URL. |
Finished benchmarking commit (1cb9a96d8ce08c33b68cca0ad459fca5e0de3668): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Footnotes |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 6e0967f with merge 75d24a7cf3e6bea5d63d71654ca373deb806edac... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #96978) made this pull request unmergeable. Please resolve the merge conflicts. |
Although there is technically a compiler change, I think this is more bootstrap, so changing label. |
Closing this as it was an experiment |
This is an experiment to see if using PGO for the compiler's own
libstd
helps performance.r? @Mark-Simulacrum