Clarify Cargo.toml's LTO parse error message #97051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
Huh, I did run |
|
Thanks for the PR! Unfortunately this isn't correct. The values that |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Okay, I will look into that. Seems pretty straightforward. The CI failure this time is from differing compile error outputs, which makes sense, to save you a click. |
|
r? @ehuss |
|
Either way, this PR specifically can be closed. |
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Jun 5, 2022
add validation for string "true"/"false" in lto profile ### What does this PR try to resolve? Adds a special-cased error message for when `lto` is set to the _string_ `"true"`/`"false"` which is surprisingly (I was surprised anyway) not allowed and the error message is ambiguous. The new error message makes it clear what values are accepted. Fixes #10572 ### How should we test and review this PR? <!-- Demonstrate how you test this change and guide reviewers through your PR. With a smooth review process, a pull request usually gets reviewed quicker. If you don't know how to write and run your tests, please read the guide: https://doc.crates.io/contrib/tests --> Uh I've not actually tested yet that's the WIP part. But put ``` [profile.dev] lto="false" ``` in your TOML and run `cargo build`, check that you get the new error message and that it makes sense and is helpful. ### Additional information It's worth noting that as per rust-lang/rust#97051 this doesn't fix the _real_ problem here IMO which is that [rust's `opt_parse_bool` cli parsing](https://github.com/rust-lang/rust/blob/491f619f564a4ff9ae4cc837e27bb919d04c31be/compiler/rustc_session/src/options.rs#L456) doesn't accept true/false which certainly seems an ad-hoc historical choice to me on first glance but also it's a much bigger change to change those semantics than this error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the TOML LTO parse error message a little more specific, to be clear that it accepts both boolean and string valued expressions.
Only taken a month to edit a single string 😅
Closes rust-lang/cargo#10572