Skip to content

Conversation

@bdbai
Copy link
Contributor

@bdbai bdbai commented May 15, 2022

The use of SetHandleInformation (introduced in #96441 to make HANDLE inheritable) breaks UWP builds because it is not available for UWP targets.

Proposed workaround: duplicate the HANDLE with inherit = true and immediately close the old one. Traditional Windows Desktop programs are not affected.

cc @ChrisDenton

@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 15, 2022
@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2022
@ChrisDenton
Copy link
Member

Thanks for the fix! Sorry for missing this. It's unfortunate that UWP isn't checked in CI.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 15, 2022

📌 Commit 4f637ee has been approved by ChrisDenton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2022
@ChrisDenton ChrisDenton added the O-windows Operating system: Windows label May 15, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2022
Rollup of 4 pull requests

Successful merges:

 - rust-lang#96947 (Add rustc_nonnull_optimization_guaranteed to Owned/Borrowed Fd/Socket)
 - rust-lang#97021 (Added note in documentation)
 - rust-lang#97042 (Add new eslint rule about brace style)
 - rust-lang#97060 (Fix use of SetHandleInformation on UWP)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d56c59e into rust-lang:master May 15, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants