fixes for time:strptime #9707
Closed
fixes for time:strptime #9707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove commented out 'X' and 'x' formats in strptime. This formats are already covered with 'T' | 'X' in line 571 and 'D' | 'x' in line 446.
Working towards rust-lang#2350
|
Would you mind adding a few test for the new functionality as well? |
|
Sure. No problem |
|
Fixed in an other PR |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
Track `clippy.toml` and `Cargo.toml` in `file_depinfo` Causes cargo to re-run clippy when those paths are modified Also tracks the path to `clippy-driver` in debug mode to remove the workarounds in `cargo dev lint` and `lintcheck` (cc `@matthiaskrgr)` changelog: Automatically re-run Clippy if `Cargo.toml` or `clippy.toml` are modified Fixes rust-lang#2130 Fixes rust-lang#8512 r? `@flip1995`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
Remove note mentioning configuration changes need cargo clean Missed this in rust-lang#9707 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would be the best way of checking if the day of the week (tm.tm_wday) has been set?
If it has been set we can use both the day of the week and the given week number (%W) to calculate the day of the year.
Having in mind, there are multiple things that could be calculated as well, like month, day of the month, etc
What I've written is a hack to show what I am trying to do, but not definitive.