-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PID to LLVM PGO profile path #97137
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ce5e532281e3313a848839a10ad80eb14ff74140 with merge 561e1f5d82bcf2d1e3175b9ece6115f0ded948f0... |
This comment has been minimized.
This comment has been minimized.
💥 Test timed out |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
@rust-timer build 561e1f5 |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ce5e532281e3313a848839a10ad80eb14ff74140 with merge 7b52047cca30b8de507625c49eed570f987fd739... |
☀️ Try build successful - checks-actions |
Queued 7b52047cca30b8de507625c49eed570f987fd739 with parent e5732a2, future comparison URL. |
Finished benchmarking commit (7b52047cca30b8de507625c49eed570f987fd739): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Footnotes |
It seems that source-level instrumentation for LLVM is not better than IR level instrumentation. Let's try once more with IR level instrumentation done by |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 1a6f29b0b3e8125c5b010903f7c7e078b720f829 with merge 5bc8c8bd82038990ccbf68b7bab76cd547a2c339... |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
Queued 5bc8c8bd82038990ccbf68b7bab76cd547a2c339 with parent 10d9ecd, future comparison URL. |
Finished benchmarking commit (5bc8c8bd82038990ccbf68b7bab76cd547a2c339): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
@bors r+ rollup=never |
📌 Commit 0b09222d20729f3d28f10e777952f107b65d26dc has been approved by |
⌛ Testing commit 0b09222d20729f3d28f10e777952f107b65d26dc with merge 0433bd1f871f18705cfb2d0677eff68bf318abf9... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
@bors retry |
@Mark-Simulacrum Can you reapprove this please? Before one benchmark was wrong after a rebase, I have fixed it. |
@bors r+ |
📌 Commit 87e97c9 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6364179): comparison url. Instruction count
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This is a continuation of #97110, which adds PID to the filename pattern of LLVM profiles. It also adds some metrics to the pgo.sh script, so that we can observe how many profiles there are and how large are they.
r? @lqd