Move some settings DOM generation out of JS #97139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 30b536e has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 18, 2022
…neration, r=notriddle Move some settings DOM generation out of JS The first commit reduce the JS size a bit by moving some DOM content generation into the HTML file directly. The second commit is an update of the `browser-ui-test` version which improves `wait-for-*` command (if the element doesn't exist, it'll wait for it instead of failing). r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#96866 (Switch CI bucket uploads to intelligent tiering) - rust-lang#97062 (Couple of refactorings to cg_ssa::base::codegen_crate) - rust-lang#97127 (Revert "Auto merge of rust-lang#96441 - ChrisDenton:sync-pipes, r=m-ou-se") - rust-lang#97131 (Improve println! documentation) - rust-lang#97139 (Move some settings DOM generation out of JS) - rust-lang#97152 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit reduce the JS size a bit by moving some DOM content generation into the HTML file directly.
The second commit is an update of the
browser-ui-testversion which improveswait-for-*command (if the element doesn't exist, it'll wait for it instead of failing).r? @notriddle