Remove unneeded null pointer asserts in ptr2int casts #97188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! |
|
📌 Commit e246735 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2022
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#96565 (rustdoc: show implementations on `#[fundamental]` wrappers) - rust-lang#97179 (Add new lint to enforce whitespace after keywords) - rust-lang#97185 (interpret/validity: separately control checking numbers for being init and non-ptr) - rust-lang#97188 (Remove unneeded null pointer asserts in ptr2int casts) - rust-lang#97189 (Update .mailmap) - rust-lang#97192 (Say "last" instead of "rightmost" in the documentation for `std::str:rfind`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 1, 2022
Ensure we never consider the null pointer dereferencable This replaces the checks that are being removed in rust-lang#97188. Those checks were too early and hence incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an assert that a pointer with address 0 has no provenance. This change is needed to support permissive provenance work in Miri, and seems justified by
ptr.with_addr(0)working and a discussion on Zulip regarding LLVM semantics.r? @RalfJung