Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename TyKind to RegionKind in comment in rustc_middle #97453

Merged
merged 1 commit into from
May 28, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 27, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 27, 2022
@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2022
@lcnr lcnr marked this pull request as ready for review May 27, 2022 14:45
@lcnr
Copy link
Contributor Author

lcnr commented May 27, 2022

do github PRs now start out as drafts by default? 🤔 Or does it reuse the selection from a previous PR

@jackh726
Copy link
Member

Can you make a better title and maybe commit message?

r=me after

@JohnTitor
Copy link
Member

do github PRs now start out as drafts by default? 🤔 Or does it reuse the selection from a previous PR

It's the latter, GitHub reuses the previous selection.

@Dylan-DPC Dylan-DPC changed the title fix comment fix typo in rustc_middle May 27, 2022
@Dylan-DPC Dylan-DPC changed the title fix typo in rustc_middle rename TyKind to RegionKind in rustc_middle May 27, 2022
@jackh726
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 27, 2022

📌 Commit 4781246 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2022
@jackh726 jackh726 changed the title rename TyKind to RegionKind in rustc_middle rename TyKind to RegionKind in comment in rustc_middle May 27, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2022
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#95214 (Remove impossible panic note from `Vec::append`)
 - rust-lang#97411 (Print stderr consistently)
 - rust-lang#97453 (rename `TyKind` to `RegionKind` in comment in rustc_middle)
 - rust-lang#97457 (Add regression test for rust-lang#81899)
 - rust-lang#97458 (Modify `derive(Debug)` to use `Self` in struct literal to avoid redundant error)
 - rust-lang#97462 (Add more eslint rules)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e96397b into rust-lang:master May 28, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 28, 2022
@lcnr lcnr deleted the comment branch May 30, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants